Unit extensions API v2 for instructors dashboard #37783

holaontiveros · 2025-12-17T20:40:18Z

Description

Adds a new endpoint to get the unit_extensions for a course that will be used on the new instructor dashboard
Modifies an utility function that needed to ignore values to unpack
Updates edx-when from 3.0.0 to 3.1.0 that has the data required for the new endpoint to import

Supporting information

Testing instructions

Make sure you have a valid course blocks that can be considered for an extension
Use the example curl request to test

example curl to test, make sure you have the right cookies and update the right IDs and details

curl --location --request GET 'http://local.openedx.io:8000/api/instructor/v2/courses/course-v1:OEXCOM+101+2025_T1/unit_extensions' \
--header 'Accept: application/json, text/javascript, */*; q=0.01' \
--header 'Referer: http://local.openedx.io:8000/courses/course-v1:OEXCOM+101+2025_T1/instructor' \
--header 'Content-Type: application/json' \
--data-raw '{
    "block_id": "block-v1:OEXCOM+101+2025_T1+type@sequential+block@c3ccd3d1f91b42dfb2bff8185dba4d3b",
    "email_or_username": "javier",
    "due_datetime": "12/12/2025 12:12",
    "reason": "Just because"
}'

a possible valid example of response of the query looks like:

{
    "next": null,
    "previous": null,
    "count": 2,
    "num_pages": 1,
    "current_page": 1,
    "start": 0,
    "results": [
        {
            "username": "armando",
            "full_name": "",
            "email": "[email protected]",
            "unit_title": "Subsection",
            "unit_location": "block-v1:OEXCOM+101+2025_T1+type@sequential+block@c3ccd3d1f91b42dfb2bff8185dba4d3b",
            "extended_due_date": "2026-12-28T00:00:00Z"
        },
        {
            "username": "javier",
            "full_name": "",
            "email": "[email protected]",
            "unit_title": "Subsection",
            "unit_location": "block-v1:OEXCOM+101+2025_T1+type@sequential+block@c3ccd3d1f91b42dfb2bff8185dba4d3b",
            "extended_due_date": "2025-12-12T12:12:00Z"
        }
    ]
}

Deadline

None

Other information

Include anything else that will help reviewers and consumers understand the change.

Requires feat: add course overrides listings for unit extensions v2 edx-when#345 to be released

openedx-webhooks · 2025-12-17T20:40:22Z

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

…rom breaking

lms/djangoapps/instructor/views/tools.py

lms/djangoapps/instructor/tests/test_api_v2.py

lms/djangoapps/instructor/views/api_v2.py

wgu-taylor-payne · 2026-01-13T23:35:42Z

lms/djangoapps/instructor/views/api_v2.py

+
+        return extension_data
+
+    def list(self, request, *args, **kwargs):


Perhaps rather than override list, we could just override filter_queryset to return the queryset passed into it.

Removing list and not overriding filter_queryset works without error because there are no default filters in place. I think it would be good to explicitly set filter_backends = [] on the class.

lms/djangoapps/instructor/views/api_v2.py

- Adjust tests for more consistent behavior - Add UnitDueDateExtension as a data interface - Reduce code duplication

dwong2708 · 2026-01-17T01:17:11Z

@wgu-taylor-payne I believe I’ve addressed all the comments. Could you please take another look?

…nsions_v2

wgu-taylor-payne · 2026-01-20T23:33:40Z

lms/djangoapps/instructor/tests/test_api_v2.py

+        data = response.data
+        results = data['results']
+
+        for r in results:


We only expect one result for each run, correct? In that case, looping wouldn't be necessary.

wgu-taylor-payne · 2026-01-20T23:38:12Z

lms/djangoapps/instructor/tests/test_api_v2.py

+            course_id = str(self.course_key)
+        return reverse('instructor_api_v2:unit_extensions', kwargs={'course_id': course_id})
+
+    def test_get_unit_extensions_success(self):


I think we could remove this one as the same things are covered in other tests.

wgu-taylor-payne · 2026-01-20T23:43:56Z

lms/djangoapps/instructor/tests/test_api_v2.py

+
+    @patch('lms.djangoapps.instructor.views.api_v2.edx_when_api.get_overrides_for_course')
+    @patch('lms.djangoapps.instructor.views.api_v2.get_units_with_due_date')
+    def test_get_unit_extensions_with_data(self, mock_get_units, mock_get_overrides):


I think test_get_unit_extensions_with_no_mockups covers what we are tyring to test here, right?

wgu-taylor-payne · 2026-01-20T23:45:15Z

lms/djangoapps/instructor/tests/test_api_v2.py

+    def test_get_unit_extensions_with_no_mockups(self):
+        """
+        Test unit extensions with mocked data.
+        """


The docstring and method name seem to clash.

wgu-taylor-payne · 2026-01-21T00:11:49Z

lms/djangoapps/instructor/tests/test_api_v2.py

+        self.assertEqual(len(results), 2)
+
+        # If there are results, verify the structure
+        extension = results[1]


I'm getting instructor data for results[0]. Is that expected?

chore: base work for unit extensions v2 api

6c87142

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 17, 2025

openedx-webhooks added this to Contributions Dec 17, 2025

github-project-automation bot moved this to Needs Triage in Contributions Dec 17, 2025

chore: fix pylint things

a2e3566

mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Dec 19, 2025

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Dec 19, 2025

holaontiveros added 5 commits January 8, 2026 14:25

chore: update to match edx-when comments

dd4b7eb

chore: update edx_when version

43deb2a

chore: restore old version before upgrade with make

7a98a89

chore: update with make upgrade-package package=edx-when

4913b98

chore: exclude extras from get_overrides_for_block to prevent tuple f…

55eef0e

…rom breaking

holaontiveros force-pushed the feature/unit_extensions_v2 branch from b4b3387 to 55eef0e Compare January 12, 2026 15:24

Merge branch 'master' into feature/unit_extensions_v2

1b9a193

holaontiveros marked this pull request as ready for review January 12, 2026 16:31

holaontiveros requested review from dwong2708, rodmgwgu and wgu-taylor-payne January 12, 2026 16:36

holaontiveros changed the title ~~[WIP] Unit extensions API v2 for instructors dashboard~~ Unit extensions API v2 for instructors dashboard Jan 12, 2026

wgu-taylor-payne reviewed Jan 13, 2026

View reviewed changes

dwong2708 suggested changes Jan 14, 2026

View reviewed changes

lms/djangoapps/instructor/views/api_v2.py Outdated Show resolved Hide resolved

lms/djangoapps/instructor/views/api_v2.py Show resolved Hide resolved

dwong2708 added 2 commits January 15, 2026 12:18

Merge branch 'master' into feature/unit_extensions_v2

0e9ea9e

feat: address review comments

9c95a16

- Adjust tests for more consistent behavior - Add UnitDueDateExtension as a data interface - Reduce code duplication

dwong2708 requested a review from wgu-taylor-payne January 17, 2026 01:15

dwong2708 and others added 3 commits January 20, 2026 13:55

Merge remote-tracking branch 'upstream/master' into feature/unit_exte…

000a598

…nsions_v2

chore: fixed lint issue

d31fd52

Merge remote-tracking branch 'upstream/master' into feature/unit_exte…

9395de4

…nsions_v2

wgu-taylor-payne reviewed Jan 21, 2026

View reviewed changes


		return extension_data

		def list(self, request, args, *kwargs):

Unit extensions API v2 for instructors dashboard #37783

Are you sure you want to change the base?

Unit extensions API v2 for instructors dashboard #37783

Conversation

holaontiveros commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Deadline

Other information

Uh oh!

openedx-webhooks commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wgu-taylor-payne Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

wgu-taylor-payne Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dwong2708 commented Jan 17, 2026

Uh oh!

wgu-taylor-payne Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

wgu-taylor-payne Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

wgu-taylor-payne Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

wgu-taylor-payne Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

wgu-taylor-payne Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

holaontiveros commented Dec 17, 2025 •

edited

Loading

openedx-webhooks commented Dec 17, 2025 •

edited

Loading

wgu-taylor-payne Jan 20, 2026 •

edited

Loading