Merge #1504

1504: fix(nvmf): reverting default CRDT to zero r=dsavitskiy a=dsavitskiy It turned out that the default non-zero CRDT causes issues with some tests. It seems to be better solution to revert it to zero, and configure the desired value in production install scripts rather having non-zero default. Co-authored-by: Dmitry Savitskiy <[email protected]>
openebs · Aug 25, 2023 · fca74e0 · fca74e0
2 parents 80a4b40 + 91e293a
commit fca74e0
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/io-engine/src/core/env.rs b/io-engine/src/core/env.rs
@@ -165,11 +165,7 @@ pub struct MayastorCliArgs {
     /// NVMF target interface (ip, mac, name or subnet).
     pub nvmf_tgt_interface: Option<String>,
     /// NVMF target Command Retry Delay.
-    #[structopt(
-        long = "tgt-crdt",
-        env = "NVMF_TGT_CRDT",
-        default_value = "30"
-    )]
+    #[structopt(long = "tgt-crdt", env = "NVMF_TGT_CRDT", default_value = "0")]
     pub nvmf_tgt_crdt: u16,
     /// api Version
     #[structopt(
@@ -237,7 +233,7 @@ impl Default for MayastorCliArgs {
             nvme_ctl_io_ctx_pool_size: 65535,
             registration_endpoint: None,
             nvmf_tgt_interface: None,
-            nvmf_tgt_crdt: 30,
+            nvmf_tgt_crdt: 0,
             api_versions: vec![ApiVersion::V0, ApiVersion::V1],
             diagnose_stack: None,
             reactor_freeze_detection: false,
@@ -381,7 +377,7 @@ impl Default for MayastorEnvironment {
             bdev_io_ctx_pool_size: 65535,
             nvme_ctl_io_ctx_pool_size: 65535,
             nvmf_tgt_interface: None,
-            nvmf_tgt_crdt: 30,
+            nvmf_tgt_crdt: 0,
             api_versions: vec![ApiVersion::V0, ApiVersion::V1],
         }
     }