Skip to content

Commit 91e293a

Browse files
committed
fix(nvmf): reverting default CRDT to zero
It turned out that the default non-zero CRDT causes issues with some tests. It seems to be better solution to revert it to zero, and configure the desired value in production install scripts rather having non-zero default. Signed-off-by: Dmitry Savitskiy <[email protected]>
1 parent 80a4b40 commit 91e293a

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

io-engine/src/core/env.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,7 @@ pub struct MayastorCliArgs {
165165
/// NVMF target interface (ip, mac, name or subnet).
166166
pub nvmf_tgt_interface: Option<String>,
167167
/// NVMF target Command Retry Delay.
168-
#[structopt(
169-
long = "tgt-crdt",
170-
env = "NVMF_TGT_CRDT",
171-
default_value = "30"
172-
)]
168+
#[structopt(long = "tgt-crdt", env = "NVMF_TGT_CRDT", default_value = "0")]
173169
pub nvmf_tgt_crdt: u16,
174170
/// api Version
175171
#[structopt(
@@ -237,7 +233,7 @@ impl Default for MayastorCliArgs {
237233
nvme_ctl_io_ctx_pool_size: 65535,
238234
registration_endpoint: None,
239235
nvmf_tgt_interface: None,
240-
nvmf_tgt_crdt: 30,
236+
nvmf_tgt_crdt: 0,
241237
api_versions: vec![ApiVersion::V0, ApiVersion::V1],
242238
diagnose_stack: None,
243239
reactor_freeze_detection: false,
@@ -381,7 +377,7 @@ impl Default for MayastorEnvironment {
381377
bdev_io_ctx_pool_size: 65535,
382378
nvme_ctl_io_ctx_pool_size: 65535,
383379
nvmf_tgt_interface: None,
384-
nvmf_tgt_crdt: 30,
380+
nvmf_tgt_crdt: 0,
385381
api_versions: vec![ApiVersion::V0, ApiVersion::V1],
386382
}
387383
}

0 commit comments

Comments
 (0)