UPSTREAM: <carry>: Move Data Science Pipelines Dockerfiles to a different path #119

VaniHaripriya · 2024-11-21T17:08:18Z

Description of your changes:
This PR resolves RHOAIENG-12124

Moved Data Science Pipelines Dockerfiles to a different path.
Adjusted all references to reflect the updated path.

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

dsp-developers · 2024-11-21T17:09:15Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...ee206ccde9cce882be28a145b8760480603a6ce3

UPSTREAM commit ee206cc has invalid summary Update Dockerfile paths.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit f13b3ef has invalid summary Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T17:10:10Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...1806d20a715c12e9f381bf32c13c35ccac1473d7

UPSTREAM commit 1806d20 has invalid summary Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T17:13:15Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...0457fe0b848fc52d07b7e20acf252f9e7b1e121a

UPSTREAM commit 0457fe0 has invalid summary Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T17:14:30Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...06d86977541c38791460039b7517eb41a3f817e3

UPSTREAM commit 06d8697 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T19:51:13Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...32ba29d488f62d85efae9b35de1038c4ff480303

UPSTREAM commit 32ba29d has invalid summary Update Dockerfile names.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 06d8697 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T19:52:43Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...fb771c22a345cedcbc27b3f1c73ce70fc0a11bc7

UPSTREAM commit fb771c2 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

odh_images/Dockerfile.cacheserver

odh_images/Dockerfile.visualization

odh_images/Dockerfile.conformance

odh_images/Dockerfile.viewercontroller

DharmitD · 2024-11-21T20:30:43Z

backend/Dockerfile.driver


-LABEL name="ds-pipelines-driver" \
-      summary="DSP Driver"
+ENTRYPOINT [ "/bin/driver" ]


nitpick: Fix EoF here.

backend/Dockerfile

DharmitD · 2024-11-21T20:36:21Z

backend/Dockerfile

+# 1. Build api server application
+FROM golang:1.21.7-bookworm as builder
+RUN apt-get update && apt-get install -y cmake clang musl-dev openssl
+WORKDIR /go/src/github.com/kubeflow/pipelines


this path needs to be pointing to where the odh/dsp APIServer code is, and not kubeflow/pipelines, I believe.

That might be causing this CI failure: https://github.com/opendatahub-io/data-science-pipelines/actions/runs/11960604493/job/33344984082?pr=119

Error from server (BadRequest): container "ml-pipeline-api-server" in pod "ml-pipeline-6cc48b7b9-zc785" is waiting to start: trying and failing to pull image

It's looking for an ml-pipeline- apiserver pod, which we find in a KFP deployment. Corresponding APIServer pod in DSP would have ds-pipelines- prefix.

@DharmitD @VaniHaripriya

From https://github.com/opendatahub-io/data-science-pipelines/pull/119/files#r1852961305:

We want to leave the upstream Dockerfiles unchanged to avoid merge conflicts during rebase. Instead, we relocated the DSP Dockerfiles to the odh_images folder

That said, it seems like we should leave the original Dockerfiles identical to upstream.
If it's causing any errors, we may need to figure out how to work around these errors without having to change the Dockerfiles that come from upstream.

Does my point of view make sense?

DharmitD · 2024-11-21T20:37:04Z

backend/Dockerfile.driver


-LABEL name="ds-pipelines-driver" \
-      summary="DSP Driver"
+ENTRYPOINT [ "/bin/driver" ]


Nitpick to fix EoF :)

openshift-ci · 2024-11-21T21:48:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rimolive. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dsp-developers · 2024-11-21T21:49:00Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...fdc04fe5a9a6bf00f23f5afd85bf02196f3b160c

UPSTREAM commit fdc04fe has invalid summary Update Dockerfile.driver.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit fb771c2 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T21:57:19Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 3 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...e2c264b8a96084c72301ea46678fe71accf76ba9

UPSTREAM commit e2c264b has invalid summary Deleted unwanted dockerfiles.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit fdc04fe has invalid summary Update Dockerfile.driver.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit fb771c2 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T21:58:30Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...26f2320b857c629856cb2cd3c2fbe15027504276

UPSTREAM commit 26f2320 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T23:04:08Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...9cc119181e88fdac645931c019ddf8e504a6a050

UPSTREAM commit 9cc1191 has invalid summary Update dockerfile path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 26f2320 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-21T23:04:52Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...58d3b66e27b8aaa9f5b9bdc0456e298d2a7155f7

UPSTREAM commit 58d3b66 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

rimolive

@VaniHaripriya I saw recently that Helber introduced a change in the Dockerfiles (see kubeflow#11348), and this will end up in merge conflicts when we rebase to 2.3.0.

I think it's safer if you copy the upstream Dockerfiles from 2.3.0 tag instead of master.

dsp-developers · 2024-11-25T17:28:15Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 2 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...f5748df8c0966efe76306108bc75ef8893a5a5f0

UPSTREAM commit f5748df has invalid summary update upstream dockerfiles.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 58d3b66 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-25T17:33:31Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 3 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...dbcc7016181fe86ecc06b877b124b3e28c7a36c6

UPSTREAM commit dbcc701 has invalid summary Update Dockerfile.driver.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit f5748df has invalid summary update upstream dockerfiles.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 58d3b66 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-25T18:26:44Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 4 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...d7e3c6b92797714e4a89cac17c5798968b3fa8d6

UPSTREAM commit d7e3c6b has invalid summary Update Dockerfile.launcher.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit dbcc701 has invalid summary Update Dockerfile.driver.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit f5748df has invalid summary update upstream dockerfiles.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 58d3b66 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

rimolive · 2024-11-25T18:27:36Z

@VaniHaripriya Don't forget that the commit messages should follow by this template:

UPSTREAM: <carry>: A carried kube change

dsp-developers · 2024-11-25T18:28:07Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 5 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...b8c80bf94508e582975947e3f4865ca3c6a81069

UPSTREAM commit b8c80bf has invalid summary Update Dockerfile.persistenceagent.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit d7e3c6b has invalid summary Update Dockerfile.launcher.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit dbcc701 has invalid summary Update Dockerfile.driver.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit f5748df has invalid summary update upstream dockerfiles.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert



UPSTREAM commit 58d3b66 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

dsp-developers · 2024-11-25T18:41:08Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...3066dd25bd3f936f4117c55de024cb71d30eeaf5

UPSTREAM commit 3066dd2 has invalid summary chore: Move Data Science Pipelines Dockerfiles to a different path.

UPSTREAM commits are validated against the following regular expression:
  ^UPSTREAM: (revert: )?(([\w.-]+/[\w-.-]+)?: )?(\d+:|<carry>:|<drop>:)

UPSTREAM commit summaries should look like:

  UPSTREAM: <PR number|carry|drop>: description

UPSTREAM commits which revert previous UPSTREAM commits should look like:

  UPSTREAM: revert: <normal upstream format>

Examples of valid summaries:

  UPSTREAM: 12345: A kube fix
  UPSTREAM: <carry>: A carried kube change
  UPSTREAM: <drop>: A dropped kube change
  UPSTREAM: revert: 12345: A kube revert

hbelmiro

@VaniHaripriya looks good in general.
I just left a few comments asking for more clarification.

Also, I'm worried about how we're going to track upstream changes and reflect them on the new Dockerfiles, if needed. Changes on those files may pass unnoticed in future rebases.
Maybe we need to add a step for reviewing changes in upstream Dockerfiles to https://github.com/opendatahub-io/data-science-pipelines/blob/master/REBASE.opendatahub.md.

hbelmiro · 2024-11-25T19:16:27Z

backend/Dockerfile

~~Why are you changing the original Dockerfiles? Is that to reflect the upstream ones?~~

Well, I think https://github.com/opendatahub-io/data-science-pipelines/pull/119/files#r1852961305 answers this question.
Please let me know, otherwise.

hbelmiro · 2024-11-25T19:21:50Z

backend/Dockerfile

+# 1. Build api server application
+FROM golang:1.21.7-bookworm as builder
+RUN apt-get update && apt-get install -y cmake clang musl-dev openssl
+WORKDIR /go/src/github.com/kubeflow/pipelines


@DharmitD @VaniHaripriya

From https://github.com/opendatahub-io/data-science-pipelines/pull/119/files#r1852961305:

We want to leave the upstream Dockerfiles unchanged to avoid merge conflicts during rebase. Instead, we relocated the DSP Dockerfiles to the odh_images folder

That said, it seems like we should leave the original Dockerfiles identical to upstream.
If it's causing any errors, we may need to figure out how to work around these errors without having to change the Dockerfiles that come from upstream.

Does my point of view make sense?

gregsheremeta · 2024-11-25T22:03:40Z

Also, I'm worried about how we're going to track upstream changes and reflect them on the new Dockerfiles

+1. I'm not a fan of this change for that reason (I think it's better to just deal with the rebasing / conflicts), but I'm out of the loop, so carry on :)

…ent path Signed-off-by: VaniHaripriya <[email protected]>

dsp-developers · 2024-11-26T16:02:00Z

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between 7c3b0204f09934458ccd7ce65deba74fb0146286...4859079ead44ffdd13e908977799f4ab0b730498

rimolive · 2024-11-26T16:24:53Z

@hbelmiro @gregsheremeta I don't think the change rate for the Dockerfiles is substantial enough that we should track changes. After all, the base images used between upstream and downstream makes us change almost the whole Dockerfile.

Working on resolving conflicts in these files during rebase is meaningless and we should avoid.

openshift-ci bot added the do-not-merge/work-in-progress label Nov 21, 2024

VaniHaripriya force-pushed the RHOAIENG-12124 branch from ee206cc to 1806d20 Compare November 21, 2024 17:09

VaniHaripriya force-pushed the RHOAIENG-12124 branch from 1806d20 to 0457fe0 Compare November 21, 2024 17:10

VaniHaripriya force-pushed the RHOAIENG-12124 branch from 0457fe0 to 06d8697 Compare November 21, 2024 17:13

VaniHaripriya force-pushed the RHOAIENG-12124 branch from 32ba29d to fb771c2 Compare November 21, 2024 19:51

VaniHaripriya marked this pull request as ready for review November 21, 2024 19:52

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 21, 2024

openshift-ci bot requested review from gregsheremeta and rimolive November 21, 2024 19:52

VaniHaripriya mentioned this pull request Nov 21, 2024

Update new Docker file paths opendatahub-io/data-science-pipelines-operator#760

Open

3 tasks

rimolive requested changes Nov 21, 2024

View reviewed changes

odh_images/Dockerfile.cacheserver Outdated Show resolved Hide resolved

odh_images/Dockerfile.visualization Outdated Show resolved Hide resolved

odh_images/Dockerfile.conformance Outdated Show resolved Hide resolved

odh_images/Dockerfile.viewercontroller Outdated Show resolved Hide resolved

openshift-ci bot assigned rimolive Nov 21, 2024

DharmitD reviewed Nov 21, 2024

View reviewed changes

backend/Dockerfile Show resolved Hide resolved

DharmitD reviewed Nov 21, 2024

View reviewed changes

VaniHaripriya force-pushed the RHOAIENG-12124 branch from e2c264b to 26f2320 Compare November 21, 2024 21:57

VaniHaripriya force-pushed the RHOAIENG-12124 branch from 9cc1191 to 58d3b66 Compare November 21, 2024 23:04

rimolive requested changes Nov 25, 2024

View reviewed changes

VaniHaripriya force-pushed the RHOAIENG-12124 branch from b8c80bf to 3066dd2 Compare November 25, 2024 18:40

hbelmiro reviewed Nov 25, 2024

View reviewed changes

UPSTREAM: <carry>:Move Data Science Pipelines Dockerfiles to a differ…

4859079

…ent path Signed-off-by: VaniHaripriya <[email protected]>

VaniHaripriya force-pushed the RHOAIENG-12124 branch from 3066dd2 to 4859079 Compare November 26, 2024 16:01

VaniHaripriya changed the title ~~chore: Move Data Science Pipelines Dockerfiles to a different path~~ UPSTREAM: <carry>: Move Data Science Pipelines Dockerfiles to a different path Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UPSTREAM: <carry>: Move Data Science Pipelines Dockerfiles to a different path #119

UPSTREAM: <carry>: Move Data Science Pipelines Dockerfiles to a different path #119

VaniHaripriya commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

DharmitD Nov 21, 2024

DharmitD Nov 21, 2024

hbelmiro Nov 25, 2024

DharmitD Nov 21, 2024

openshift-ci bot commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

rimolive left a comment

dsp-developers commented Nov 25, 2024

dsp-developers commented Nov 25, 2024

dsp-developers commented Nov 25, 2024

rimolive commented Nov 25, 2024

dsp-developers commented Nov 25, 2024

dsp-developers commented Nov 25, 2024

hbelmiro left a comment

hbelmiro Nov 25, 2024

hbelmiro Nov 25, 2024

gregsheremeta commented Nov 25, 2024

dsp-developers commented Nov 26, 2024

rimolive commented Nov 26, 2024 •

edited

Loading

UPSTREAM: <carry>: Move Data Science Pipelines Dockerfiles to a different path #119

Are you sure you want to change the base?

UPSTREAM: <carry>: Move Data Science Pipelines Dockerfiles to a different path #119

Conversation

VaniHaripriya commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

DharmitD Nov 21, 2024

Choose a reason for hiding this comment

DharmitD Nov 21, 2024

Choose a reason for hiding this comment

hbelmiro Nov 25, 2024

Choose a reason for hiding this comment

DharmitD Nov 21, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Nov 21, 2024

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

dsp-developers commented Nov 21, 2024

Commit Checker results:

rimolive left a comment

Choose a reason for hiding this comment

dsp-developers commented Nov 25, 2024

Commit Checker results:

dsp-developers commented Nov 25, 2024

Commit Checker results:

dsp-developers commented Nov 25, 2024

Commit Checker results:

rimolive commented Nov 25, 2024

dsp-developers commented Nov 25, 2024

Commit Checker results:

dsp-developers commented Nov 25, 2024

Commit Checker results:

hbelmiro left a comment

Choose a reason for hiding this comment

hbelmiro Nov 25, 2024

Choose a reason for hiding this comment

hbelmiro Nov 25, 2024

Choose a reason for hiding this comment

gregsheremeta commented Nov 25, 2024

dsp-developers commented Nov 26, 2024

Commit Checker results:

rimolive commented Nov 26, 2024 • edited Loading

rimolive commented Nov 26, 2024 •

edited

Loading