Skip to content

Commit

Permalink
Update Dockerfile paths
Browse files Browse the repository at this point in the history
  • Loading branch information
VaniHaripriya committed Nov 21, 2024
1 parent f13b3ef commit ee206cc
Show file tree
Hide file tree
Showing 9 changed files with 36 additions and 36 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,17 @@ jobs:
matrix:
include:
- image: ds-pipelines-api-server
dockerfile: backend/Dockerfile
dockerfile: odh_images/Dockerfile
- image: ds-pipelines-frontend
dockerfile: frontend/Dockerfile
- image: ds-pipelines-persistenceagent
dockerfile: backend/Dockerfile.persistenceagent
dockerfile: odh_images/Dockerfile.persistenceagent
- image: ds-pipelines-scheduledworkflow
dockerfile: backend/Dockerfile.scheduledworkflow
dockerfile: odh_images/Dockerfile.scheduledworkflow
- image: ds-pipelines-driver
dockerfile: backend/Dockerfile.driver
dockerfile: odh_images/Dockerfile.driver
- image: ds-pipelines-launcher
dockerfile: backend/Dockerfile.launcher
dockerfile: odh_images/Dockerfile.launcher
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/build
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@ jobs:
matrix:
include:
- image: ds-pipelines-api-server
dockerfile: backend/Dockerfile
dockerfile: odh_images/Dockerfile
- image: ds-pipelines-frontend
dockerfile: frontend/Dockerfile
- image: ds-pipelines-persistenceagent
dockerfile: backend/Dockerfile.persistenceagent
dockerfile: odh_images/Dockerfile.persistenceagent
- image: ds-pipelines-scheduledworkflow
dockerfile: backend/Dockerfile.scheduledworkflow
dockerfile: odh_images/Dockerfile.scheduledworkflow
- image: ds-pipelines-driver
dockerfile: backend/Dockerfile.driver
dockerfile: odh_images/Dockerfile.driver
- image: ds-pipelines-launcher
dockerfile: backend/Dockerfile.launcher
dockerfile: odh_images/Dockerfile.launcher
steps:
- uses: actions/checkout@v3
- name: Generate Tag
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/build-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@ jobs:
matrix:
include:
- image: ds-pipelines-api-server
dockerfile: backend/Dockerfile
dockerfile: odh_images/Dockerfile
- image: ds-pipelines-frontend
dockerfile: frontend/Dockerfile
- image: ds-pipelines-persistenceagent
dockerfile: backend/Dockerfile.persistenceagent
dockerfile: odh_images/Dockerfile.persistenceagent
- image: ds-pipelines-scheduledworkflow
dockerfile: backend/Dockerfile.scheduledworkflow
dockerfile: odh_images/Dockerfile.scheduledworkflow
- image: ds-pipelines-driver
dockerfile: backend/Dockerfile.driver
dockerfile: odh_images/Dockerfile.driver
- image: ds-pipelines-launcher
dockerfile: backend/Dockerfile.launcher
dockerfile: odh_images/Dockerfile.launcher
steps:
- uses: actions/checkout@v3
- name: Build Image
Expand Down
14 changes: 7 additions & 7 deletions backend/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ BUILD=build
MOD_ROOT=..
CSV_PATH=backend/third_party_licenses

# Whenever build command for any of the binaries change, we should update them both here and in backend/Dockerfiles.
# Whenever build command for any of the binaries change, we should update them both here and in odh_images/Dockerfiles.

.PHONY: all
all: license_apiserver license_persistence_agent license_cache_server license_swf license_viewer license_driver license_launcher
Expand Down Expand Up @@ -55,19 +55,19 @@ image_all: image_apiserver image_persistence_agent image_cache image_swf image_v

.PHONY: image_apiserver
image_apiserver:
cd $(MOD_ROOT) && docker build -t apiserver -f backend/Dockerfile .
cd $(MOD_ROOT) && docker build -t apiserver -f odh_images/Dockerfile .
.PHONY: image_persistence_agent
image_persistence_agent:
cd $(MOD_ROOT) && docker build -t persistence-agent -f backend/Dockerfile.persistenceagent .
cd $(MOD_ROOT) && docker build -t persistence-agent -f odh_images/Dockerfile.persistenceagent .
.PHONY: image_cache
image_cache:
cd $(MOD_ROOT) && docker build -t cache-server -f backend/Dockerfile.cacheserver .
cd $(MOD_ROOT) && docker build -t cache-server -f odh_images/Dockerfile.cacheserver .
.PHONY: image_swf
image_swf:
cd $(MOD_ROOT) && docker build -t scheduledworkflow -f backend/Dockerfile.scheduledworkflow .
cd $(MOD_ROOT) && docker build -t scheduledworkflow -f odh_images/Dockerfile.scheduledworkflow .
.PHONY: image_viewer
image_viewer:
cd $(MOD_ROOT) && docker build -t viewercontroller -f backend/Dockerfile.viewercontroller .
cd $(MOD_ROOT) && docker build -t viewercontroller -f odh_images/Dockerfile.viewercontroller .
.PHONY: image_visualization
image_visualization:
cd $(MOD_ROOT) && docker build -t visualization -f backend/Dockerfile.visualization .
cd $(MOD_ROOT) && docker build -t visualization -f odh_images/Dockerfile.visualization .
4 changes: 2 additions & 2 deletions backend/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Finally, it is advised to install [pre-commit](https://pre-commit.com/) in order
The API server image can be built from the root folder of the repo using:
```
export API_SERVER_IMAGE=api_server
docker build -f backend/Dockerfile . --tag $API_SERVER_IMAGE
docker build -f odh_images/Dockerfile . --tag $API_SERVER_IMAGE
```
## Deploy APIServer with the image you own build

Expand Down Expand Up @@ -76,5 +76,5 @@ dependencies.

Run
```
docker build . -f backend/Dockerfile.conformance -t <tag>
docker build . -f odh_images/Dockerfile.conformance -t <tag>
```
2 changes: 1 addition & 1 deletion backend/src/cache/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
To build the Docker image of cache server, run the following Docker command from the pipelines directory:

```
docker build -t gcr.io/ml-pipeline/cache-server:latest -f backend/Dockerfile.cacheserver .
docker build -t gcr.io/ml-pipeline/cache-server:latest -f odh_images/Dockerfile.cacheserver .
```

## Deploy cache service to an existing KFP deployment
Expand Down
14 changes: 7 additions & 7 deletions developer_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ To build the API server image and upload it to GCR on x86_64 machines:

```bash
# Run in the repository root directory
$ docker build -t gcr.io/<your-gcp-project>/api-server:latest -f backend/Dockerfile .
$ docker build -t gcr.io/<your-gcp-project>/api-server:latest -f odh_images/Dockerfile .
# Push to GCR
$ gcloud auth configure-docker
$ docker push gcr.io/<your-gcp-project>/api-server:latest
Expand All @@ -26,7 +26,7 @@ To build the API server image and upload it to GCR on non-x86_64 machines (such

```bash
# Run in the repository root directory
$ docker build -t gcr.io/<your-gcp-project>/api-server:latest -f backend/Dockerfile
$ docker build -t gcr.io/<your-gcp-project>/api-server:latest -f odh_images/Dockerfile
# Push to GCR
$ gcloud auth configure-docker
$ docker push gcr.io/<your-gcp-project>/api-server:latest
Expand All @@ -36,7 +36,7 @@ To build the scheduled workflow controller image and upload it to GCR:

```bash
# Run in the repository root directory
$ docker build -t gcr.io/<your-gcp-project>/scheduledworkflow:latest -f backend/Dockerfile.scheduledworkflow .
$ docker build -t gcr.io/<your-gcp-project>/scheduledworkflow:latest -f odh_images/Dockerfile.scheduledworkflow .
# Push to GCR
$ gcloud auth configure-docker
$ docker push gcr.io/<your-gcp-project>/scheduledworkflow:latest
Expand All @@ -46,7 +46,7 @@ To build the viewer CRD controller image and upload it to GCR:

```bash
# Run in the repository root directory
$ docker build -t gcr.io/<your-gcp-project>/viewer-crd-controller:latest -f backend/Dockerfile.viewercontroller .
$ docker build -t gcr.io/<your-gcp-project>/viewer-crd-controller:latest -f odh_images/Dockerfile.viewercontroller .
# Push to GCR
$ gcloud auth configure-docker
$ docker push gcr.io/<your-gcp-project>/viewer-crd-controller:latest
Expand All @@ -56,7 +56,7 @@ To build the persistence agent image and upload it to GCR:

```bash
# Run in the repository root directory
$ docker build -t gcr.io/<your-gcp-project>/persistenceagent:latest -f backend/Dockerfile.persistenceagent .
$ docker build -t gcr.io/<your-gcp-project>/persistenceagent:latest -f odh_images/Dockerfile.persistenceagent .
# Push to GCR
$ gcloud auth configure-docker
$ docker push gcr.io/<your-gcp-project>/persistenceagent:latest
Expand All @@ -66,7 +66,7 @@ To build the visualization server image and upload it to GCR:

```bash
# Run in the repository root directory
$ docker build -t gcr.io/<your-gcp-project>/visualization:latest -f backend/Dockerfile.visualization .
$ docker build -t gcr.io/<your-gcp-project>/visualization:latest -f odh_images/Dockerfile.visualization .
# Push to GCR
$ gcloud auth configure-docker
$ docker push gcr.io/<your-gcp-project>/visualization:latest
Expand All @@ -89,7 +89,7 @@ Minikube can pick your local Docker image so you don't need to upload to remote
For example, to build API server image

```bash
$ docker build -t ml-pipeline-api-server -f backend/Dockerfile .
$ docker build -t ml-pipeline-api-server -f odh_images/Dockerfile .
```

## Python based visualizations
Expand Down
6 changes: 3 additions & 3 deletions scripts/deploy/github/build-images.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ TAG="${TAG:-latest}"

docker system prune -a -f

docker build -q -t "${REGISTRY}/apiserver:${TAG}" -f backend/Dockerfile . && docker push "${REGISTRY}/apiserver:${TAG}" &
docker build -q -t "${REGISTRY}/persistenceagent:${TAG}" -f backend/Dockerfile.persistenceagent . && docker push "${REGISTRY}/persistenceagent:${TAG}" &
docker build -q -t "${REGISTRY}/scheduledworkflow:${TAG}" -f backend/Dockerfile.scheduledworkflow . && docker push "${REGISTRY}/scheduledworkflow:${TAG}" &
docker build -q -t "${REGISTRY}/apiserver:${TAG}" -f odh_images/Dockerfile . && docker push "${REGISTRY}/apiserver:${TAG}" &
docker build -q -t "${REGISTRY}/persistenceagent:${TAG}" -f odh_images/Dockerfile.persistenceagent . && docker push "${REGISTRY}/persistenceagent:${TAG}" &
docker build -q -t "${REGISTRY}/scheduledworkflow:${TAG}" -f odh_images/Dockerfile.scheduledworkflow . && docker push "${REGISTRY}/scheduledworkflow:${TAG}" &

wait

Expand Down
2 changes: 1 addition & 1 deletion test/cloudbuild/api_server.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
steps:
- id: "api-server"
name: "gcr.io/cloud-builders/docker"
args: ['build', '-t', '$_GCR_BASE/api-server', '-f', 'backend/Dockerfile', '--build-arg', 'COMMIT_SHA=abcdefg', '--build-arg', 'TAG_NAME=1.0-dev', '.']
args: ['build', '-t', '$_GCR_BASE/api-server', '-f', 'odh_images/Dockerfile', '--build-arg', 'COMMIT_SHA=abcdefg', '--build-arg', 'TAG_NAME=1.0-dev', '.']
timeout: 1800s # 30min
options:
machineType: N1_HIGHCPU_8 # This is cpu intensive, use a better machine.
Expand Down

0 comments on commit ee206cc

Please sign in to comment.