Update RegEx patterns for annotation IDs #751
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to issue #315, but it is a band-aid solution for the current state of database IDs, not an automatic solution as suggested in the issue.
The Regex patterns which are used to match against annotation IDs in
test_*_annotation_wrong_ids
tests have gone out of date since they were last updated. This PR replaces out-of-date ID patterns with the latest versions retrieved from https://registry.identifiers.org/registry.I first noticed this problem when evaluating a model which uses a refseq id in the format
WP_*
, which is now a valid ID. While updating this pattern, I noticed that others have gone out of date as well and have updated them too.All previous tests in
tests/test_for_support/test_for_annotation.py
still apply and pass, and no additional functionality which would require tests has been introduced.