fix(live-proof): flush recorder packets and trust a live ffmpeg session - #1191
Merged
Conversation
Terminal recordings still failed the readiness probe with an empty file while ffmpeg captured frames: the WebM muxer buffers whole clusters in memory, so a mostly static xterm screen can produce zero file bytes well past the probe window. The recorder now flushes packets immediately, and an alive recorder session at the probe deadline counts as healthy since finalize, ffprobe, and the duration cap already validate substance.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): flush recorder packets and trust a live ffmpeg session This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Even after #1190, terminal recordings failed the readiness probe with an empty output file while the recorder pane showed ffmpeg capturing frames (openclaw/openclaw#110714, run 32027540959): the WebM muxer buffers whole clusters in memory, and a mostly static xterm screen can legitimately produce zero file bytes well past any probe window. Recorders now run with
-flush_packets 1so the file reflects capture progress immediately, and the readiness probe treats a live recorder session at the deadline as healthy — a dead session still fails fast with pane diagnostics, and finalize, ffprobe, and the duration cap continue to validate substance.Validation
pnpm buildclean; live-proof suite 18/18.