fix(live-proof): fall back to a single poster frame for short recordings - #1192
Merged
Conversation
The contact-sheet tile needs about 100 seconds of sampled video before hosted ffmpeg builds emit a frame, so demonstrations shorter than that produced no poster and failed the bundle (openclaw/openclaw#110714 run 32028028690). Short recordings now retry with a single scaled frame near the start of the demo before failing.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): fall back to a single poster frame for short recordings This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the recorder fixed (#1191), terminal live proofs progressed to poster generation and failed there: the contact-sheet filter (
fps=1/5,tile=5x4) needs ~100 seconds of sampled video before hosted ffmpeg builds emit a tile, and short demonstrations produced no poster at all (openclaw/openclaw#110714, run 32028028690; local ffmpeg 7 flushes a partial tile, runner ffmpeg 6 does not). Short recordings now fall back to a single scaled frame near the start of the demonstration, keeping the strict existence check.Validation
pnpm buildclean; live-proof suite 18/18.