fix(live-proof): accept bursty VP9 recorder output and tune realtime capture - #1190
Merged
Conversation
…capture Production terminal recordings (openclaw/openclaw#122341 run 32025434010) showed ffmpeg capturing frames while the growth probe demanded strictly increasing sizes between one-second samples, which VP9's bursty muxer never guarantees. The recorder is now accepted once any payload is written, VP9 encodes with realtime deadline tuning so hosted runners hold the frame rate, and the workflow assertion learns the xfonts-base dependency added in #1188.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): accept bursty VP9 recorder output and tune realtime capture This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminal recordings kept failing with "raw WebM did not begin growing within 15 seconds" while the recorder pane showed ffmpeg capturing frames normally (openclaw/openclaw#122341, run 32025434010). Two causes: the readiness probe demanded strictly increasing file sizes between one-second samples, which VP9's bursty muxer never guarantees, and default VP9 encoding cannot hold 30fps on a two-core hosted runner. The recorder is now accepted once any payload is written (finalize and ffprobe still verify substance), VP9 encodes with
-deadline realtime -cpu-used 8, and the workflow assertion learns thexfonts-basedependency from #1188, which branch-scoped CI had missed.Validation
pnpm buildclean; live-proof suite 18/18; full unit suite green in parallel with review (exit 0).