fix(live-proof): dispatch from every review-record publication lane - #1185
Merged
Conversation
Consolidate live-proof dispatch into a shared composite action and invoke it from all four durable publication lanes, including the hot exact-review batch publish workflow that the queue-service split left without one. A new static assertion requires every durable review-record publication lane to invoke dispatch-live-proofs so future lanes cannot silently drop it.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): dispatch from every review-record publication lane This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
steipete
added a commit
that referenced
this pull request
Aug 17, 2026
…nal driver (#1186) The first production terminal recording (openclaw/crabbox#1379, run 32017763576) failed because ffmpeg launched against the xvfb display before it accepted connections and died silently inside its detached tmux session. The driver now polls xdpyinfo for display readiness, waits for the recorder output to exist and grow, waits for the recorder to exit after finalize, and attaches capture-pane diagnostics from all three sessions to any failure. Also registers the batch-publish dispatch lane's setup-state site in the state-writer audits, which were red on main since #1185.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production watch after #1184 showed zero live-proof dispatches despite continuous review publication. Root cause: the queue-service split moved hot-lane publication into
exact-review-batch-publish.yml, which never received a dispatch step; a fourth lane (exact-artifact fallback delivery) was also uncovered.Live-proof dispatch is now one composite action —
.github/actions/dispatch-live-proofs— invoked from all four durable review-record publication lanes (direct exact-event delivery, exact-artifact fallback delivery, scheduled record publication, and per-repository batch publication from accepted receipts). A new static assertion requires every durable review-record publication lane to invoke the action, so a future lane split cannot silently drop dispatch again — the failure class this fixes.Validation
pnpm buildandpnpm build:repairclean; unit suite green (141 files).pnpm run checkgreen, including the 269-file coverage suite and the new lane-coverage assertion.