fix(live-proof): wait for display and recorder readiness in the terminal driver - #1186
Merged
Merged
Conversation
…nal driver The first production terminal recording (openclaw/crabbox#1379, run 32017763576) failed because ffmpeg launched against the xvfb display before it accepted connections and died silently inside its detached tmux session. The driver now polls xdpyinfo for display readiness, waits for the recorder output to exist and grow, waits for the recorder to exit after finalize, and attaches capture-pane diagnostics from all three sessions to any failure. Also registers the batch-publish dispatch lane's setup-state site in the state-writer audits, which were red on main since #1185.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): wait for display and recorder readiness in the terminal driver This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first production terminal live proof (openclaw/crabbox#1379, run 32017763576 — an organic, model-recommended dispatch from a fallback-profiled repo) failed with "terminal driver did not finalize a recording": ffmpeg launched against the xvfb display after a fixed one-second sleep, before Xvfb accepted connections, and died silently inside its detached tmux session.
The terminal driver now polls readiness at every boundary —
xdpyinfountil the display accepts connections (30s bound), recorder output existence and growth (15s), and recorder exit after finalize (20s) — and attachestmux capture-panediagnostics from all three sessions to any failure.x11-utilsjoins the workflow's recording tools. All polling goes through the injected runner with tests covering slow display, late-appearing recorder files, dead recorders, and finalize waits.Also registers the batch-publish dispatch lane's
setup-statesite in the state-writer audits — those two audits have been red on main since #1185 (the site itself met every invariant; only the audited inventory was missing the entry).Validation
pnpm buildclean; full unit suite 2,291 passed, 0 failed.