Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgin: refine span name formatting and deprecate SpanNameFormatter option #6381

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into otelgin-span

1d9b5f5
Select commit
Loading
Failed to load commit list.
Draft

otelgin: refine span name formatting and deprecate SpanNameFormatter option #6381

Merge branch 'main' into otelgin-span
1d9b5f5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2024 in 1s

67.0% (+0.0%) compared to 0fc2c4c

View this Pull Request on Codecov

67.0% (+0.0%) compared to 0fc2c4c

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (0fc2c4c) to head (1d9b5f5).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6381   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        193     193           
  Lines      15660   15674   +14     
=====================================
+ Hits       10494   10514   +20     
+ Misses      4876    4872    -4     
+ Partials     290     288    -2     
Files with missing lines Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 89.6% <100.0%> (-0.3%) ⬇️
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes