Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgin: refine span name formatting and deprecate SpanNameFormatter option #6381

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Nov 28, 2024

source: #6375

supplements:

  • The Gin framework does not support mixed case or lowercase methods. Therefore, I removed this part of the single test.

@flc1125 flc1125 requested a review from a team as a code owner November 28, 2024 15:58
@github-actions github-actions bot requested a review from akats7 November 28, 2024 15:59
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.0%. Comparing base (0fc2c4c) to head (1d9b5f5).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6381   +/-   ##
=====================================
  Coverage   67.0%   67.0%           
=====================================
  Files        193     193           
  Lines      15660   15674   +14     
=====================================
+ Hits       10494   10514   +20     
+ Misses      4876    4872    -4     
+ Partials     290     288    -2     
Files with missing lines Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 89.6% <100.0%> (-0.3%) ⬇️
...ntation/github.com/gin-gonic/gin/otelgin/option.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@flc1125 flc1125 changed the title refactor(otelgin): refine span name formatting and deprecate SpanNameFormatter option otelgin: refine span name formatting and deprecate SpanNameFormatter option Nov 28, 2024
@dmathieu
Copy link
Member

dmathieu commented Dec 3, 2024

Based on the ongoing discussions with the need or not for SpanNameFormatter, could you update this PR to only include the default span name?

@flc1125
Copy link
Member Author

flc1125 commented Dec 3, 2024

Based on the ongoing discussions with the need or not for SpanNameFormatter, could you update this PR to only include the default span name?

OK, I will add another draft version of the PR (which may not have passed unit testing and CI).

@flc1125
Copy link
Member Author

flc1125 commented Dec 3, 2024

@dmathieu A draft version: #6396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants