Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: adhere to the HTTP span naming semconv processing checklist #6375

Open
3 tasks
flc1125 opened this issue Nov 27, 2024 · 5 comments
Open
3 tasks

todo: adhere to the HTTP span naming semconv processing checklist #6375

flc1125 opened this issue Nov 27, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@flc1125
Copy link
Member

flc1125 commented Nov 27, 2024

Based on #6365 (comment), organize the following list of items that need to be processed:

  • go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux
  • go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin
  • go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

If there are any omissions, please let me know.

Reference solution:

https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6365/files

References:

@flc1125 flc1125 added the enhancement New feature or request label Nov 27, 2024
@flc1125 flc1125 changed the title Pending: adhere to the HTTP span naming semconv processing checklist. todo: adhere to the HTTP span naming semconv processing checklist. Nov 28, 2024
@flc1125 flc1125 changed the title todo: adhere to the HTTP span naming semconv processing checklist. todo: adhere to the HTTP span naming semconv processing checklist Nov 28, 2024
@flc1125
Copy link
Member Author

flc1125 commented Nov 28, 2024

To avoid repetition, synchronize as follows:

I am processing this: go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin

@dmathieu
Copy link
Member

dmathieu commented Nov 29, 2024

I don't think we should remove the custom span methods.

See open-telemetry/opentelemetry-collector#11230
As a valid use of a custom span name.

@flc1125
Copy link
Member Author

flc1125 commented Nov 30, 2024

@dmathieu @pellared

Hello, since there are some questions at present, I want to discuss them together.

Information:

  • At present, there are still situations in the community that expect customizable span names;
  • But standard semantics suggest a fixed format.

So my current thoughts are:

  • Keep customizable span naming, but mark it as obsolete through comments, explain the use of standard semantic annotations, and recommend using the default naming format
  • Change the default naming of all related tables to standard semantics.

Because there is a difference from the previous treatment method. Therefore, I would like to invite the two of you to discuss it together and see how to deal with it.


reference:

@pellared
Copy link
Member

pellared commented Dec 2, 2024

I think this can be split this into two issues:

  1. Change the default span naming to adhere to semantic conventions
  2. Deprecate (and later remove) SpanNameFormatter

We may decide just to address the first issue if there would be a push-back to keep SpanNameFormatter

@flc1125
Copy link
Member Author

flc1125 commented Dec 2, 2024

I think this can be split this into two issues:

  1. Change the default span naming to adhere to semantic conventions
  2. Deprecate (and later remove) SpanNameFormatter

We may decide just to address the first issue if there would be a push-back to keep SpanNameFormatter

Good idea, I will first solve the first problem. For the second problem, I will leave it as is for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants