[chore] Update go versions used in workflows #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Sep 6, 2023
jpkrohling
approved these changes
Sep 8, 2023
jpkrohling
reviewed
Sep 8, 2023
| @@ -49,7 +49,7 @@ jobs: | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v4 | |||
| with: | |||
| go-version: '~1.21' | |||
There was a problem hiding this comment.
While this looks fine and low-risk, should we apply those changes first in the core/contrib repos, to ensure that everything is fully tested before preparing a release?
Like here:
There was a problem hiding this comment.
Yes, the PRs have already been made to collector core and contrib.
There was a problem hiding this comment.
My PR is merely forcing a minimum version. minor version v1.21 is already being used in these workflows.
codeboten
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a defensive PR to update the go versions to force a minimum version. The latest patch versions contains security related fixes.