Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update go versions used in workflows #395

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[chore] Update go versions used in workflows #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: '~1.21'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this looks fine and low-risk, should we apply those changes first in the core/contrib repos, to ensure that everything is fully tested before preparing a release?

Like here:

https://github.com/open-telemetry/opentelemetry-collector/blob/03b56b6bca3fc2fca53a19fea849538de4dfda47/.github/workflows/build-and-test.yml#L22

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the PRs have already been made to collector core and contrib.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR is merely forcing a minimum version. minor version v1.21 is already being used in these workflows.

go-version: '~1.21.1'
check-latest: true

- name: Generate the sources
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: '~1.21'
go-version: '~1.21.1'
check-latest: true

- name: Verify
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

- uses: actions/setup-go@v4
with:
go-version: '~1.21'
go-version: '~1.21.1'
check-latest: true

- name: Generate distribution sources
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:

- uses: actions/setup-go@v4
with:
go-version: '~1.21'
go-version: '~1.21.1'
check-latest: true

- uses: actions/download-artifact@v3
Expand Down