-
Notifications
You must be signed in to change notification settings - Fork 68
added model location and steps to run docker with gazebo models (Closes #669) #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pratheeshprakash
wants to merge
11
commits into
open-rmf:main
Choose a base branch
from
pratheeshprakash:update-readme-issue-#669
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added model location and steps to run docker with gazebo models (Closes #669) #672
pratheeshprakash
wants to merge
11
commits into
open-rmf:main
from
pratheeshprakash:update-readme-issue-#669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratheesh Prakash <[email protected]>
aaronchongth
requested changes
Apr 21, 2025
Member
aaronchongth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to keep the original instructions, and add these additional instructions below them, mentioning that if folks encounter the same model-missing issue, they can try this
Signed-off-by: Pratheesh Prakash <[email protected]>
…/pratheeshprakash/rmf into update-readme-issue-open-rmf#669
Signed-off-by: Pratheesh Prakash <[email protected]>
d49e2b9 to
06c74bb
Compare
Signed-off-by: Pratheesh Prakash <[email protected]>
Signed-off-by: Pratheesh Prakash <[email protected]>
Signed-off-by: Pratheesh Prakash <[email protected]>
Signed-off-by: Pratheesh Prakash <[email protected]>
…/pratheeshprakash/rmf into update-readme-issue-open-rmf#669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Fix applied
If your pull request is a bug fix, delete this line and all the below lines.
If your pull request is a feature implementation, delete this line and all the above lines.
New feature implementation
Implemented feature
Implementation description