Skip to content

Conversation

@orensbruli
Copy link
Contributor

Docker files and repos modified to run in humble.

@orensbruli orensbruli requested a review from Yadunund August 29, 2022 09:28
@Yadunund
Copy link
Member

There is already an effort to migrate to humble here #165 but a blocker seems to be related to libceres.

@orensbruli
Copy link
Contributor Author

I have also looked into that PRand also investigated the problem and commented in this issue open-rmf/rmf_traffic_editor#439
I think that while nightly is using ros-tooling/[email protected] and that action installs libc++-dev by default, we are gonna get this conflict until libgoogle-glog-dev is updated to libunwind-14-dev or we remove the libc++-dev from ros-tooling/[email protected] (related: ros-tooling/setup-ros#506)
My suggestion would be to proceed with updating the two files in this PR and then keep the blocker only for the nightly.yaml file.
What do you think?

@Yadunund
Copy link
Member

I see thanks for explaining that.
Would it be more streamlined if we merge this PR into the humble-image branch first? So target humble-image and not main.

@orensbruli orensbruli changed the base branch from main to humble-image September 1, 2022 07:19
@orensbruli orensbruli changed the base branch from humble-image to main September 1, 2022 08:40
@orensbruli
Copy link
Contributor Author

orensbruli commented Sep 1, 2022

I see thanks for explaining that. Would it be more streamlined if we merge this PR into the humble-image branch first? So target humble-image and not main.

True.
Then I think that my modifications to the Dockerfile should go to https://github.com/open-rmf/rmf_deployment_template/blob/main/rmf/builder-rosdep.Dockerfile right?

@orensbruli orensbruli closed this by deleting the head repository Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants