Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
schemars generates schemas with
additionalProperties: false
for enums.When the enum is flatten, that
additionalProperties: false
is inherited by the parentstruct, which leads to schemas that can never be valid.
Example:
Here the section schema needs to have a
builder
ortemplate
with no additional properties.Which includes other properties like
type
,config
etc, buttype
is also required whichbreaks the schema.
Fix applied
Remove
additionalProperties
from the flattened field. The newunevaluatedProperties
option in new json schema drafts addresses this issue, but schemars uses draft-07 so we can't use it. We could update the schema to draft-2020-12 but it's better not to make potentially breaking change.If your pull request is a bug fix, delete this line and all the below lines.
If your pull request is a feature implementation, delete this line and all the above lines.
New feature implementation
Implemented feature
Implementation description