Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight GUI polish on top of #168 #169

Closed
wants to merge 7 commits into from
Closed

Slight GUI polish on top of #168 #169

wants to merge 7 commits into from

Conversation

smathot
Copy link
Collaborator

@smathot smathot commented Aug 25, 2024

I changed the layout of the study panel such that the buttons sit on a row above the tabs, like this:

Screenshot from 2024-08-25 13-39-14

Otherwise it won't look nice except on very wide windows. Can you briefly check this and then merge? That also takes care of #168 then.

@smathot smathot requested a review from kristian-lange August 25, 2024 12:40
@kristian-lange
Copy link
Collaborator

I actually tried the grow/shrink layout and it worked on my laptop (Thinkpad with normal screen resolution). Even when I reduced the screen size a bit with the developer tools and opened the OMM's sidebar to squeeze it even more it was all fine with no wrapping. I'm not against a two rows solution but then we should take out the grow/shrink stuff because it's not necessary anymore and just confusing. It's up to you: two rows or grow/shrink?

@kristian-lange
Copy link
Collaborator

@smathot Ping! There is still a decision to be made. Revert the grow/shrink stuff and go with your changes or the other way around. Your call.

@smathot
Copy link
Collaborator Author

smathot commented Sep 17, 2024

We need two rows for this. The issue is not that it wraps on small windows, but that the tabs don't fit and show a kind of scroll button which you need to click in order to access the Statistics tab.

@kristian-lange
Copy link
Collaborator

Not sure what you mean. It looks fine in my browser. But if you prefer to rows, it will be two rows. I just have to remove the grow/shrink stuff.

Screencast.from.21.09.2024.10.05.47.webm

@smathot
Copy link
Collaborator Author

smathot commented Sep 21, 2024

This video looks good, indeed. What I experienced was that the tab bar shrunk so that the statistics option was no longer visible (but hidden behind a horizontal scroll button). We don't need to get to the bottom of why this behavior is different now. The way it is on your video is good, so go ahead and merge! (Can you do that because otherwise I may merge from the wrong point.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants