Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous GUI enhancement (#167) #168

Merged
merged 6 commits into from
Oct 3, 2024

Conversation

kristian-lange
Copy link
Collaborator

@kristian-lange kristian-lange commented Aug 15, 2024

This PR deals with the first 4 points of #167

  • Statistics should be on an independent tab (with info, jobs, participants), not in participants. So we could order the tabs like this: INFO / JOBS / PARTICIPANTS / STATISTICS
  • Downloading data button should be with other buttons and it should always be in csv format (there is no need for the other options or the cached version, this is never used).
  • Buttons would therefore be: Experiment / Job / Data / Archive / Delete / Sharing
  • The manage participants Button of the participants tab should be at the top of the panel, not the bottom.

Edit: change link

@smathot smathot changed the title Miscellaneous GUI enhancemet (#167) Miscellaneous GUI enhancement (#167) Aug 16, 2024
@smathot
Copy link
Collaborator

smathot commented Aug 16, 2024

It looks good, but two minor things before I merge.

  1. The tab manager is too narrow, so that it has < and > buttons on either side. This is because it has a max-width of 33.3%, which doesn't fit anymore. But if the tab manager is allowed to grow, it won't fit with the buttons next to it. My suggestions would be that the buttons are right-aligned in a row above the tab manager. Another layout is fine too, as long as elements are not unnecessarily hidden on realistically sized screens.

image

  1. Two of the unittests are currently failing:
  • resources/pages/dashboard/studies/_id/index.test.js
  • resources/components/Participants/ParticipantsPanel/ParticipantsPanel.test.js

I assume this is just because they haven't been updated to reflect the revised GUI. But could you make sure that they pass, either by updating them. (Or if you feel that they are excessive, removing them?)

@kristian-lange
Copy link
Collaborator Author

The tab manager is too narrow, so that it has < and > buttons on either side. This is because it has a max-width of 33.3%, which doesn't fit anymore. But if the tab manager is allowed to grow, it won't fit with the buttons next to it. My suggestions would be that the buttons are right-aligned in a row above the tab manager. Another layout is fine too, as long as elements are not unnecessarily hidden on realistically sized screens.

We can use the flex system for that to let the columns grow and shrink and take as much space as needed. It's a small change. Have a look at 7a6fa3d.

@kristian-lange
Copy link
Collaborator Author

@smathot If you agree (see #169) we can merge this PR then. But unfortunately I can't since I have no write access to this repo.

@smathot smathot merged commit 74590f8 into open-cogsci:master Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants