Fix regression #117
Open
Fix regression #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git 2.17.0 changes the "n" in this string from upper to lower case, which in turn caused an empty git status prompt when not in a checked-out git repository. This patch addresses both scenarios. Yes, it was as annoying to track down as you probably think.
peikk0
suggested changes
Apr 4, 2018
| error_string = error.decode('utf-8') | ||
|
|
||
| if 'fatal: Not a git repository' in error_string: | ||
| if 'fatal: Not a git repository' in error_string.lower(): |
There was a problem hiding this comment.
as @peikk0 said 'fatal: Not a git repository' should be 'fatal: not a git repository'
|
Too bad this repo is unmaintained :/ Thanks for the PR anyway :) |
|
Hi. There is the better fix in #119 |
mttrs
added a commit
to mttrs/zsh-git-prompt
that referenced
this pull request
Apr 29, 2018
From git 2.17.0, it appears that the error string changes. olivierverdier#117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git 2.17.0 changes the "n" in this string from upper to lower case, which in turn caused an empty git status prompt when not in a checked-out git repository. This patch addresses both scenarios.
Yes, it was as annoying to track down as you probably think.