empty git status (:|✔) shows up even in non git directories

[choufleur]

The command
RPROMPT='$(git_super_status)'
in my .zshrc has for effect that in a non git directory I get (:|✔)

This wasn't the case until my recent switch to fedora 26. Any idea on how to fix this issue ?

[apoutchika]

I have same issue on fresh install of debian 9...

[456Xander]

I also have this issue on Manjaro

[soner89]

I have the same issue on ArchLinux. Every directory have (:|✔) in the prompt, even if it's not a git initialized directory.

[nimag42]

It happens because the python script doesn't find "fatal: Not a git repository" in error message and doesn't exit as author's designed it (line 15 in gitstatus.py)
For example if your system is set on another language (french for me), the error message doesn't contain the string.

If your system is in english and you still have the problem, can you print the result of git status in a non-git folder to debug ?

A simple fix could be this :

diff --git a/zshrc.sh b/zshrc.sh
index 87b43fa..e513393 100644
--- a/zshrc.sh
+++ b/zshrc.sh
@@ -63,7 +63,8 @@ function update_current_git_vars() {
 
 git_super_status() {
        precmd_update_git_vars
-    if [ -n "$__CURRENT_GIT_STATUS" ]; then
+    if [ "$GIT_BRANCH" != ":" ]; then
          STATUS="$ZSH_THEME_GIT_PROMPT_PREFIX$ZSH_THEME_GIT_PROMPT_BRANCH$GIT_BRANCH%{${reset_color}%}"
          if [ "$GIT_BEHIND" -ne "0" ]; then
                  STATUS="$STATUS$ZSH_THEME_GIT_PROMPT_BEHIND$GIT_BEHIND%{${reset_color}%}"

@olivierverdier, would you accept such a fix, or isn't it clean enough for you ? (I haven't tested it to see if this introduces new bugs...)

[choufleur]

@nimag42 your guessed right : my system is set on French as well.

[quinnypig]

Just found this; there was a regression as well that changed the case. #117 fixes this on my (English) system.

[jonbarksdale]

I'm seeing this again as well.

[Segaja]

My suggested fix for this:

diff --git a/gitstatus.py b/gitstatus.py
index d944fd4..28bdad4 100755
--- a/gitstatus.py
+++ b/gitstatus.py
@@ -12,7 +12,7 @@ branch, error = gitsym.communicate()
 
 error_string = error.decode('utf-8')
 
-if 'fatal: Not a git repository' in error_string:
+if 'fatal: not a git repository' in error_string.lower():
        sys.exit(0)
 
 branch = branch.decode("utf-8").strip()[11:]

That way the system doesn't care in which case the git binary returns this error.

[fam4r]

@nimag42 solves for me
@quinnypig @Segaja does not solve for me

Loaded with zgen in Arch Linux

[Segaja]

check what the output of git symbolic-ref HEAD is on your system. I see this as an error that the python script doesn't realize there is no repository.

[fam4r]

@Segaja
In a non-git folder the output is:

git symbolic-ref HEAD
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

[Segaja]

Hm this should work. did you apply the entire change? the lowercasing of the first string and the .lower() function at the end?

[fam4r]

Hi @Segaja ,

I used @quinnypig patch (branch in his fork) in my zgen load, which changes exactely what you said.

[Segaja]

That is not enough. According to #117 he only added the .lower() call at the end, but the "N" of "fatal: Not a git repository" is still uppercase.

So essentially this line checks if the string "fatal: Not a git repository" is present in the output of the git symbolic-ref HEAD command. But for some reason the cases of the words changed, that is why I propose to lowercase the command output (... in error_string.lower(): but then also lowercase the needle you search: "fatal: not a git repository".

[Segaja]

Upon thinking more about this and reading above that some people have non-english system, maybe it makes more sense not to check the error string, but the return code of the command.
I forked the project and created #119 to push my changes back into this master.