Test /events and /labels, especially auth #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename the test case. * it's no longer necessary to set app.debug
Also in label_resources.py:
* Change a logger.warning to a logging.debug, since it's not a server issue if this happens (and was chattering at the test suite)
* Letter logger.{debug,info} do the string formatting instead of passing it formatted strings — for style and efficiency
|
@songbird175 if you've got work on this branch ready to go you can push and it will go in this PR. Otherwise rebase from or merge dev once this is merged. (I'm trying to keep mergeable changes from hanging out on branches for too long.) |
songbird175
approved these changes
May 5, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b7f354e Add more event tests
Starts #103.
Creates stubs for #75 (marked in
test_events.pyby a TODO).Issues #218, #217, #216 and ,#215 should add to these tests.
937445b Minor improvements to test_events.py
2adaea2 Add test cases for /labels
Also in
label_resources.py:logger.warningtologging.debug, since it's not a server issue if this happens (and this was chattering at the test suite)logger.{debug,info}do the string formatting instead of passing it formatted strings — for style and efficiency