Fix import calendar; add cookie-based auth #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test update to python 3.6.5 and force env in travis
Fix flake8 errors in the top-level (celery) *.py files
This reverts commit 41c97e7.
Run flake8 against tests
* Rename the test case. * it's no longer necessary to set app.debug
Also in label_resources.py:
* Change a logger.warning to a logging.debug, since it's not a server issue if this happens (and was chattering at the test suite)
* Letter logger.{debug,info} do the string formatting instead of passing it formatted strings — for style and efficiency
Origin/seamless/new emails
Test /events and /labels, especially auth
Adds an authorized cookie
Fixes auth tests
Import fix
osteele
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
01768db Switched to EmailMessage format, added time to confirmations, updated tests
1a7e8d5 Merge branch 'dev' into origin/seamless/new-emails
6aaed59 *Flake8 the top-level (celery) .py files
f99047b Test update to python 3.6.5 and force env in travis
ae4cc1e Trying out more cutting edge travis
7eab537 Don't need to install 3.6.5 with pyenv
25a454d Merge pull request #209 from olinlibrary/jwb/python-upgrade
Test update to python 3.6.5 and force env in travis
d63d19f Added emailing back a link to edit event
4f2de51 Merge branch 'dev' into origin/seamless/new-emails
7560950 Merge pull request #205 from olinlibrary/osteele/flake8-celery
Fix flake8 errors in the top-level (celery) *.py files
e5e45b6 Merge branch 'dev' into origin/seamless/new-emails
92bf778 Fixed flake8 errors
d7cb83e Removed unnecessary mock objects
8d2416f Scaffolds use of a cookie for auth
9a13163 Removed extra steps to formating email
acdea31 Run flake8 against tests
b7f354e Add more event tests
Starts #103.
Creates stubs for #75 (marked in
test_events.pyby a TODO).Issues #218, #217, #216 and ,#215 should add to these tests.
6541525 Fixes comment typo
272af43 Adds working cookie auth
41c97e7 Upgrade to flask 1.0, breaks tests
c91f2e1 Revert "Upgrade to flask 1.0, breaks tests"
This reverts commit 41c97e7.
7d8f547 Adresses test failures
4eefc3e Adds tests for auth cookie
30f7453 merge test auth flake8 fixes
b41f87e Adds more test cases
e7dd469 Update SHARED_SECRET description
c78d26c Factors out auth check
158217d Merge pull request #220 from olinlibrary/osteele/flake8-tests
Run flake8 against tests
4b35300 Wraps cookie tests in subtests
eb42fe2 Merge branch 'dev' into jwb/auth-secret
3bc56f9 Github merge editor doesn't lint for PEP8
937445b Minor improvements to test_events.py
2adaea2 Add test cases for /labels
Also in
label_resources.py:logger.warningto alogging.debug, since it's not a server issue if this happens (and was chattering at the test suite)logger.{debug,info}do the string formatting instead of passing it formatted strings — for style and efficiencyba99c7c Merge branch 'dev' into origin/seamless/new-emails
4817476 Fixing flake8
0a26c49 adding indents
21d6071 Actually managed correct indenting
5eebfda Remove unused import
2f5355f Merge pull request #219 from olinlibrary/origin/seamless/new-emails
Origin/seamless/new emails
d765131 Merge pull request #223 from olinlibrary/osteele/test-events
Test
/eventsand/labels, especially auth4d3a248 Merge pull request #222 from olinlibrary/jwb/auth-secret
Adds an authorized cookie
8ed00fb Fixes auth tests
8432b1f clean up tests
fbc7724 A little more tidying
12c4956 Merge pull request #226 from olinlibrary/jwb/fixtests
Fixes auth tests
73a21fa Fixed and added tests for failure to import URL
0523cad Fixed error with URL imports and added tests
Resolves olin-build/abe-web#204
702a7d8 Reenabled new test.
e4dd6de fix a typo
26af86a Merge pull request #232 from olinlibrary/import-fix
Import fix