Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some labels confer automatic public visibility #216

Open
osteele opened this issue May 3, 2018 · 0 comments
Open

Some labels confer automatic public visibility #216

osteele opened this issue May 3, 2018 · 0 comments
Labels
auth Authorization and authentication
Projects

Comments

@osteele
Copy link
Contributor

osteele commented May 3, 2018

Some labels make their events publicly visible.

This could be implemented something like:

Computing event visibility could happen after the mongodb query, something like:

public_label_names = {label.name for label in db.Label.objects(public=True)}
results = [event for event in results if not set(event.labels).isdisjoint(public_label_names) ]

This isn't terribly efficient, but it's probably adequate, and if the server is getting hammered by outside visitors we probably want a more generic caching layer anyway.

This task should also propose the set of label (Featured? Academic Calendar? Collaboratory?) that have public visibility.

@osteele osteele added the auth Authorization and authentication label May 3, 2018
@osteele osteele added this to Product Backlog in Roadmap via automation May 3, 2018
osteele added a commit that referenced this issue May 4, 2018
Starts #103.

Creates stubs for #75 (marked in `test_events.py` by a TODO).

Issues #218, #217, #216 and ,#215 should add to these tests.
@osteele osteele changed the title Some tags confer automatic public visibility Some labels confer automatic public visibility May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth Authorization and authentication
Projects
Roadmap
  
Product Backlog
Development

No branches or pull requests

1 participant