Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks to the footer #1127

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Small tweaks to the footer #1127

merged 1 commit into from
Nov 20, 2024

Conversation

pdelboca
Copy link
Member

Implements changes suggested in #1125 (comment)

Changes:

  • Left alignment: the licence section should follow the line of the logo.
  • Right alignment: the menu should end with the social media icons.
  • Size of social media icons: reduce by 10%.
  • Spacing: slightly increase the spacing between the licence items.
  • CKAN: replace the logo with a version without the DPG symbol (it is disproportionate to the other items)

@pdelboca pdelboca requested a review from avdata99 November 20, 2024 16:38
@pdelboca pdelboca merged commit 5142d9e into develop Nov 20, 2024
2 checks passed
@pdelboca pdelboca deleted the 1125-css-fixes-to-footer branch November 20, 2024 16:40
@pdelboca pdelboca mentioned this pull request Nov 21, 2024
Merged
@lucpretti
Copy link
Contributor

The new footer looks good. Please move it to production.

@pdelboca pdelboca mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdata99 avdata99 avdata99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdelboca @lucpretti @avdata99