ANZU - Technical Training #728

annzzu · 2025-04-22T13:18:08Z

No description provided.

robodoo · 2025-04-22T13:18:11Z

- initialization of Real estate module [email protected]

- add estate.property - add estate.property basic fields [email protected]

- add estate.property security access [email protected]

- add estate.property menus, action - add estate.property state selection field - add estate.property field attributes [email protected]

- add estate.property basic views - ref estate.property field names [email protected]

- Created property type, tag, and offer models. - Added many2one (type, buyer, seller), many2many (tags), and one2many (offers) relations to property model. [email protected]

- add computed fields: total_area, best_price, date_deadline. - add Onchange: Default garden area and orientation. [email protected]

- Add "Cancel" and "Sold" buttons to estate.property with state change logic and constraints. - Add "Accept" and "Refuse" buttons to estate.property.offer. - Accepting an offer sets the property's buyer and selling price. - Added constraint that only one offer can be accepted per property. [email protected]

SergeBayet

Great start @annzzu ! Some remarks, mainly linting problem.

SergeBayet · 2025-04-23T07:43:33Z

.gitignore

@@ -127,3 +127,5 @@ dmypy.json

 # Pyre type checker
 .pyre/
+
+.idea


@annzzu Missing blank line at the end of the file

SergeBayet · 2025-04-23T07:43:39Z

estate/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-
+from . import models


blank line still missing at the EOF

SergeBayet · 2025-04-23T07:44:20Z

estate/__manifest__.py

+        "views/estate_property_tag_views.xml",
+        "views/estate_menus.xml",
+    ],
+    'license': 'AGPL-3'


Prefer the license "LGPL-3"

SergeBayet · 2025-04-23T07:44:58Z

estate/__manifest__.py

+    'author': "Odoo",
+    'website': "https://www.odoo.com/",
+    'category': 'Tutorials/Real Estate',
+    'version': '18.0.1.7.0',


The version of your module have to be applied. So, 1.0 should be consistent.

SergeBayet · 2025-04-23T07:46:18Z

estate/models/estate_property.py

+            ('accepted', "Offer Accepted"),
+            ('sold', "Sold"),
+            ('cancelled', "Cancelled"),
+        ], required=True, copy=False, default='new',


This is not a list or a dict, they are arguments of the method Selection, no need to add a comma at the end.

Suggested change

], required=True, copy=False, default='new',

], required=True, copy=False, default='new'

SergeBayet · 2025-04-23T07:48:56Z

estate/security/ir.model.access.csv

+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
+estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
+estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
+estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1


blank line at the end of the file.

SergeBayet · 2025-04-23T07:49:04Z

estate/views/estate_menus.xml

+            <menuitem id="menu_property_tag" action="estate_property_tag_action" name="Property Tags"/>
+        </menuitem>
+    </menuitem>
+</odoo>


SergeBayet · 2025-04-23T07:49:11Z

estate/views/estate_property_tag_views.xml

+            <field name="view_mode">list,form</field>
+        </record>
+    </data>
+</odoo>


SergeBayet · 2025-04-23T07:49:16Z

estate/views/estate_property_type_views.xml

+            <field name="view_mode">list,form</field>
+        </record>
+    </data>
+</odoo>


SergeBayet · 2025-04-23T07:49:26Z

estate/views/estate_property_views.xml

+            <field name="search_view_id" ref="estate_property_search"/>
+        </record>
+    </data>
+</odoo>


and same here

SergeBayet

You can remove all the utf-8 encoding at the top of your files. That's the default value.

SergeBayet · 2025-04-23T08:01:35Z

estate/__manifest__.py

@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-


Not necessary, you can remove it.

SergeBayet · 2025-04-23T08:01:48Z

estate/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-


Not necessary.

SergeBayet · 2025-04-23T08:02:21Z

estate/models/__init__.py

@@ -0,0 +1,6 @@
+# -*- coding: utf-8 -*-


Suggested change

# -*- coding: utf-8 -*-

SergeBayet · 2025-04-23T08:30:51Z

estate/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-
+from . import models


blank line still missing at the EOF

- Inline views - Widgets & Attributes: Enhanced field display and behavior. - List features: Configured default ordering and enabled quick edits. - Search: Improved filtering options. - Stat button: Added link to related offers. - [REF] refactoring feedback [email protected]

SergeBayet · 2025-04-23T08:40:06Z

@annzzu You have 2 more linting problems: see below:

SergeBayet · 2025-04-23T08:48:11Z

Yeah! Congrats:

- Implemented Python inheritance to modify create and delete behavior. - Extended res.users model to include salesperson properties. - Modified user form view to display assigned properties. [email protected]

SergeBayet · 2025-04-23T11:11:39Z

estate/models/estate_property_offer.py

+            property_id.write({
+                'state': 'received',
+            })
+        return super(EstatePropertyOffer, self).create(vals_list)


That's not necessary anymore with the recent version of Python:

super().create(vals_list)

- Created estate_account link module, dependent on estate and account. - Extended estate.property model to generate invoices on sale. Implemented invoice creation, including invoice lines for sales commission (6%) and admin fees (100). [email protected]

- Basic Kanban View for estate.property [email protected]

- Creating objects from xml [email protected]

SergeBayet

Seems good to me. 👍

SergeBayet · 2025-04-28T08:55:23Z

@annzzu
Runbot is not happy:

- refactoring the code [email protected]

- Chapter 1: Owl components (Displaying a counter) [email protected]

- Chapter 1.2: Owl components (Extract Counter in a sub component) [email protected]

- Chapter 1.4: Owl components (Using markup to display html) [email protected]

- Chapter 1.5: Owl components (Props validation) [email protected]

- Chapter 1.6: Owl components (The sum of two Counter) [email protected]

- Chapter 1.7: Owl components (A todo list) [email protected]

SergeBayet · 2025-04-29T08:29:16Z

awesome_owl/static/src/playground.js

@@ -3,11 +3,12 @@
 const {markup, Component, useState} = owl;
 import {Counter} from "./counter/counter";
 import {Card} from "./card/card";
+import {TodoList} from "./todo_list/todo_list";


In JS we put a blank space after the opening curly brace and before the closing one.
import { TodoList }
Check your linter (EsLint) 👍

SergeBayet

@annzzu Her's my review. Some remarks. Pay attention to the tab indentations in your xml files.

SergeBayet · 2025-04-29T13:40:38Z

awesome_owl/static/src/counter/counter.js

+     }
+
+     increment() {
+         this.state.value = this.state.value + 1;


you can use this.state.value++

SergeBayet · 2025-04-29T13:40:44Z

awesome_owl/static/src/counter/counter.js

+     increment() {
+         this.state.value = this.state.value + 1;
+     }
+ }


Blank line missing, and on the other files too.

SergeBayet · 2025-04-29T13:41:58Z

.gitignore

@@ -127,3 +127,5 @@ dmypy.json

 # Pyre type checker
 .pyre/
+
+.idea


This file should not be in your commit.

SergeBayet · 2025-04-29T13:42:15Z

awesome_owl/static/src/card/card.js

@@ -0,0 +1,10 @@
+import {Component} from "@odoo/owl";


Suggested change

import {Component} from "@odoo/owl";

import { Component } from "@odoo/owl";

SergeBayet · 2025-04-29T13:42:47Z

awesome_owl/static/src/card/card.xml

+        <div class="card d-inline-block m-2" style="width: 18rem;">
+            <div class="card-body">
+               <h5 class="card-title"><t t-out="props.title"/></h5>
+                <p class="card-text"><t t-out="props.content"/></p>


indentation here.

SergeBayet · 2025-04-29T13:45:41Z

awesome_owl/static/src/counter/counter.js

+    }
+
+    static props = {
+        onChange: {type: Function, optional: true}


Suggested change

onChange: {type: Function, optional: true}

onChange: { type: Function, optional: true }

SergeBayet · 2025-04-29T13:46:29Z

awesome_owl/static/src/counter/counter.xml

+<templates xml:space="preserve">
+     <t t-name="awesome_owl.Counter">
+         <div class="m-2 p-2 border d-inline-block">


first indentation is 5 and the second one is 4. Intended?

SergeBayet · 2025-04-29T13:47:22Z

awesome_owl/static/src/playground.xml

+            <Counter onChange.bind="incrementSum" />
+             <Counter onChange.bind="incrementSum" />


indentation... :)

SergeBayet · 2025-04-29T13:47:44Z

awesome_owl/static/src/todo_list/todo_item.js

+            shape: {
+                id: Number,
+                description: String,
+                isCompleted: Boolean


linting

Suggested change

isCompleted: Boolean

isCompleted: Boolean,

SergeBayet · 2025-04-29T13:48:44Z

estate/demo/demo_data.xml

+<!--        <field name="facades">4</field>-->
+<!--        <field name="garage">False</field>-->
+<!--    </record>-->
+


annzzu force-pushed the 18.0-tutorial-anzu branch from 5223520 to beaeb92 Compare April 22, 2025 13:58

[ADD] estate: Chapter 2: real estate module initialization

cba07ab

- initialization of Real estate module [email protected]

annzzu force-pushed the 18.0-tutorial-anzu branch from 03a3238 to cba07ab Compare April 22, 2025 20:22

Ana Zurabashvili [anzu] added 8 commits April 22, 2025 22:30

[IMP] estate: Chapter 3 (Models And Basic Fields)

023a65c

- add estate.property - add estate.property basic fields [email protected]

[IMP] estate: Chapter 4 (Security - A Brief Introduction)

9910739

- add estate.property security access [email protected]

[IMP] estate: Chapter 5: Finally, Some UI To Play With

661f6d9

- add estate.property menus, action - add estate.property state selection field - add estate.property field attributes [email protected]

[IMP] estate: Chapter 6: Basic Views

bd46a93

- add estate.property basic views - ref estate.property field names [email protected]

[IMP] estate: Chapter 7: Relations Between Models

0333d71

- Created property type, tag, and offer models. - Added many2one (type, buyer, seller), many2many (tags), and one2many (offers) relations to property model. [email protected]

[IMP] estate: Chapter 8: Computed Fields And On changes

8c226cb

- add computed fields: total_area, best_price, date_deadline. - add Onchange: Default garden area and orientation. [email protected]

annzzu changed the title ~~[ANZU] Technical Training~~ ANZU - Technical Training Apr 22, 2025

SergeBayet suggested changes Apr 23, 2025

View reviewed changes

SergeBayet reviewed Apr 23, 2025

View reviewed changes

annzzu force-pushed the 18.0-tutorial-anzu branch from 664c01d to ca6f8e6 Compare April 23, 2025 08:32

SergeBayet suggested changes Apr 23, 2025

View reviewed changes

estate/__init__.py Outdated

@@ -0,0 +1,2 @@

# -*- coding: utf-8 -*-

from . import models

Copy link

SergeBayet Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line still missing at the EOF

annzzu force-pushed the 18.0-tutorial-anzu branch from ca6f8e6 to 43b8619 Compare April 23, 2025 08:36

[REF] estate: feedback linting refactoring

c520c52

[IMP] estate: Chapter 12: Inheritance

b2ea8d0

- Implemented Python inheritance to modify create and delete behavior. - Extended res.users model to include salesperson properties. - Modified user form view to display assigned properties. [email protected]

SergeBayet suggested changes Apr 23, 2025

View reviewed changes

Ana Zurabashvili [anzu] added 3 commits April 23, 2025 14:26

[IMP] estate: Chapter 14: A Brief History Of QWeb

7adcf7d

- Basic Kanban View for estate.property [email protected]

[IMP] estate: Define module data

a3f4d61

- Creating objects from xml [email protected]

SergeBayet approved these changes Apr 23, 2025

View reviewed changes

[REF] estate,estate_account: Refactoring code

94c487e

- refactoring the code [email protected]

annzzu force-pushed the 18.0-tutorial-anzu branch from 0618f39 to 94c487e Compare April 28, 2025 20:06

Ana Zurabashvili [anzu] added 2 commits April 28, 2025 22:07

[IMP] awesome_owl: Discover the web framework 1.1

f8747b2

- Chapter 1: Owl components (Displaying a counter) [email protected]

[IMP] awesome_owl: Discover the web framework 1.2

672627d

- Chapter 1.2: Owl components (Extract Counter in a sub component) [email protected]

annzzu force-pushed the 18.0-tutorial-anzu branch from a352b28 to 66382e7 Compare April 28, 2025 20:25

[IMP] awesome_owl: Discover the web framework 1.4

d3f94bb

- Chapter 1.4: Owl components (Using markup to display html) [email protected]

annzzu force-pushed the 18.0-tutorial-anzu branch from 66382e7 to d3f94bb Compare April 28, 2025 20:37

Ana Zurabashvili [anzu] added 3 commits April 28, 2025 22:38

[IMP] awesome_owl: Discover the web framework 1.5

7ac29c7

- Chapter 1.5: Owl components (Props validation) [email protected]

[IMP] awesome_owl: Discover the web framework 1.6

dce032b

- Chapter 1.6: Owl components (The sum of two Counter) [email protected]

[IMP] awesome_owl: Discover the web framework 1.7

eeb342c

- Chapter 1.7: Owl components (A todo list) [email protected]

SergeBayet reviewed Apr 29, 2025

View reviewed changes

SergeBayet suggested changes Apr 29, 2025

View reviewed changes

	], required=True, copy=False, default='new',
	], required=True, copy=False, default='new'

	import {Component} from "@odoo/owl";
	import { Component } from "@odoo/owl";

	onChange: {type: Function, optional: true}
	onChange: { type: Function, optional: true }

		<Counter onChange.bind="incrementSum" />
		<Counter onChange.bind="incrementSum" />

ANZU - Technical Training #728

Are you sure you want to change the base?

ANZU - Technical Training #728

Conversation

annzzu commented Apr 22, 2025

robodoo commented Apr 22, 2025

SergeBayet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeBayet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SergeBayet commented Apr 23, 2025

SergeBayet commented Apr 23, 2025

Choose a reason for hiding this comment

SergeBayet left a comment

Choose a reason for hiding this comment

SergeBayet commented Apr 28, 2025

Choose a reason for hiding this comment

SergeBayet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment