[IMP] estate: Chapter 11: Add The Sprinkles

- Inline views
- Widgets & Attributes: Enhanced field display and behavior.
- List features: Configured default ordering and enabled quick edits.
- Search: Improved filtering options.
- Stat button: Added link to related offers.
- [REF] refactoring feedback

[email protected]

Author: Ana Zurabashvili [anzu]

estate/__init__.py

@@ -1,2 +1 @@
-# -*- coding: utf-8 -*-
 from . import models

estate/__manifest__.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 {
     'name': "Real Estate",
     'summary': """
@@ -10,7 +9,7 @@
     'author': "Odoo",
     'website': "https://www.odoo.com/",
     'category': 'Tutorials/Real Estate',
-    'version': '18.0.1.7.0',
+    'version': '1.0',
     'application': True,
     'installable': True,
     'depends': ['base'],
@@ -19,7 +18,8 @@
         "views/estate_property_views.xml",
         "views/estate_property_type_views.xml",
         "views/estate_property_tag_views.xml",
+        "views/estate_property_offer_views.xml",
         "views/estate_menus.xml",
     ],
-    'license': 'AGPL-3'
+    'license': "LGPL-3",
 }

estate/models/__init__.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from . import estate_property
 from . import estate_property_tag
 from . import estate_property_type

estate/models/estate_property.py

@@ -1,5 +1,4 @@
 from dateutil.relativedelta import relativedelta
-
 from odoo import api, fields, models
 from odoo.exceptions import UserError
 from odoo.exceptions import ValidationError
@@ -9,13 +8,14 @@
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate Property"
+    _order = "id desc"
 
     name = fields.Char(string="Title", required=True)
     description = fields.Text(string="Description")
     postcode = fields.Char(string="Postcode")
     date_availability = fields.Date(
         default=lambda self: fields.Date.today() + relativedelta(months=3),
-        string="Available From", copy=False,
+        string="Available From", copy=False
     )
     expected_price = fields.Float(string="Property Expected Price", required=True)
     selling_price = fields.Float(string="Selling Price", readonly=True, copy=False)
@@ -32,7 +32,7 @@ class EstateProperty(models.Model):
             ('south', "South"),
             ('east', "East"),
             ('west', "West"),
-        ],
+        ]
     )
     state = fields.Selection(
         string="State",
@@ -42,7 +42,7 @@ class EstateProperty(models.Model):
             ('accepted', "Offer Accepted"),
             ('sold', "Sold"),
             ('cancelled', "Cancelled"),
-        ], required=True, copy=False, default='new',
+        ], required=True, copy=False, default='new'
     )
     buyer_id = fields.Many2one("res.partner")
     salesman_id = fields.Many2one("res.users", default=lambda self: self.env.user)
@@ -51,23 +51,27 @@ class EstateProperty(models.Model):
     offer_ids = fields.One2many('estate.property.offer', 'property_id',
                                 string="Offers")
 
-    total_area = fields.Float(string="Total Area", compute="_compute_total_area",
+    total_area = fields.Float(string="Total Area", compute='_compute_total_area',
                               store=True)
 
     best_price = fields.Float(string="Best price",
                               compute='_compute_best_price', store=True)
+    is_offer_excepted = fields.Boolean(string="Offer Excepted",
+                                       compute='_compute_is_offer_excepted')
+    is_available = fields.Boolean(string="Available", compute='_compute_is_available',
+                                  store=True)
 
     _sql_constraints = [
         (
-            "check_expected_price_positive",
-            "CHECK(expected_price >= 0)",
-            "Expected price must be strictly positive.",
+            'check_expected_price_positive',
+            'CHECK(expected_price >= 0)',
+            'Expected price must be strictly positive.',
         ),
         (
-            "check_selling_price_positive",
-            "CHECK(selling_price >= 0)",
-            "Selling price must be strictly positive.",
-        ),
+            'check_selling_price_positive',
+            'CHECK(selling_price >= 0)',
+            'Selling price must be strictly positive.',
+        )
     ]
 
     @api.depends('garden_area', 'living_area')
@@ -80,15 +84,25 @@ def _compute_best_price(self):
         for val in self:
             val.best_price = max(val.offer_ids.mapped('price'), default=0)
 
+    @api.depends('offer_ids.state')
+    def _compute_is_offer_excepted(self):
+        for val in self:
+            val.is_offer_excepted = any(x.state == 'accepted' for x in val.offer_ids)
+
+    @api.depends('state')
+    def _compute_is_available(self):
+        for val in self:
+            val.is_available = val.state in ('new', 'received')
+
     def action_sold(self):
         if self.state == 'cancelled':
-            raise UserError('Cancelled property cannot be sold.')
+            raise UserError("Cancelled property cannot be sold.")
         self.state = 'sold'
 
     def action_cancel(self):
         for val in self:
             if val.state == 'sold':
-                raise UserError('Sold property cannot be cancelled.')
+                raise UserError("Sold property cannot be cancelled.")
             val.state = 'cancelled'
 
     @api.onchange('garden')
@@ -100,7 +114,7 @@ def _onchange_garden(self):
             self.garden_area = False
             self.garden_orientation = False
 
-    @api.constrains("expected_price", "selling_price")
+    @api.constrains('expected_price', 'selling_price')
     def _check_selling_price_vs_expected(self):
         for rec in self:
             if float_is_zero(rec.selling_price or 0.0, precision_digits=2):
@@ -111,8 +125,3 @@ def _check_selling_price_vs_expected(self):
                 raise ValidationError(
                     "Here Selling price must be at least 90% of the expected price."
                 )
-            # if rec.selling_price and rec.selling_price <= rec.expected_price * 0.90:
-            #     raise ValidationError(
-            #         "Selling price should not be possible to accept an offer lower "
-            #         "than 90% of the expected price",
-            #     )

estate/models/estate_property_offer.py

@@ -4,24 +4,31 @@
 
 
 class EstatePropertyOffer(models.Model):
-    _name = "estate.property.offer"
-    _description = "Estate Property Offer"
+    _name = 'estate.property.offer'
+    _description = 'Estate Property Offer'
+    _order = 'price desc'
 
-    price = fields.Float()
-    status = fields.Selection(
+    price = fields.Float("Price")
+    state = fields.Selection(
+        "State",
         selection=[
-            ("accepted", "Accepted"),
-            ("refused", "Refused")
-        ], copy=False,
+            ('accepted', "Accepted"),
+            ('refused', "Refused")
+        ], copy=False
     )
-    partner_id = fields.Many2one("res.partner", required=True)
-    property_id = fields.Many2one("estate.property", required=True)
-
-    date_deadline = fields.Date(string="Deadline Date",
-                                compute="_compute_date_deadline",
-                                inverse="_inverse_date_deadline")
-    validity = fields.Integer(string="Validity Days", default=7)
+    partner_id = fields.Many2one('res.partner',
+                                 "Partner",
+                                 required=True)
+    property_id = fields.Many2one("estate.property",
+                                  "Property",
+                                  required=True)
+    date_deadline = fields.Date("Deadline Date",
+                                compute='_compute_date_deadline',
+                                inverse='_inverse_date_deadline')
+    validity = fields.Integer("Validity Days", default=7)
 
+    property_type_id = fields.Many2one('estate.property.type',
+                                       related='property_id.type_id', store=True)
     _sql_constraints = [
         (
             "check_price_positive",
@@ -47,19 +54,19 @@ def _inverse_date_deadline(self):
     def action_accept(self):
         for val in self:
             self.property_id.offer_ids.filtered(
-                lambda x: x.status == "accepted").write({
-                'status': "refused",
+                lambda x: x.state == 'accepted').write({
+                'state': 'refused',
             })
 
-            val.status = 'accepted'
+            val.state = 'accepted'
             val.property_id.write({
                 'buyer_id': val.partner_id.id,
                 'selling_price': val.price,
             })
 
     def action_refuse(self):
         for val in self:
-            val.status = 'refused'
+            val.state = 'refused'
             val.property_id.write({
                 'buyer_id': False,
                 'selling_price': False,

estate/models/estate_property_tag.py

@@ -4,8 +4,10 @@
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Estate Property Tag"
+    _order = "name"
 
     name = fields.Char(string="Property Tag", required=True)
+    color = fields.Integer(string="Color")
 
     _sql_constraints = [
         ('unique_name', 'unique(name)',

estate/models/estate_property_type.py

@@ -1,13 +1,28 @@
-from odoo import fields, models
+from odoo import api, fields, models
 
 
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type"
+    _order = "sequence desc"
 
     name = fields.Char(string="Property Type", required=True)
+    sequence = fields.Integer(string="Sequence", default=1)
+    property_ids = fields.Many2many(
+        "estate.property",
+    )
+
+    offer_ids = fields.One2many('estate.property.offer', 'property_type_id',
+                                string="Offers")
+
+    offer_count = fields.Integer(string="Offer Count", compute="_compute_offer_count")
 
     _sql_constraints = [
         ('unique_name', 'unique(name)',
          'Types should have unique names.'),
     ]
+
+    @api.depends("offer_ids")
+    def _compute_offer_count(self):
+        for val in self:
+            val.offer_count = len(val.offer_ids)

estate/security/ir.model.access.csv

@@ -2,4 +2,4 @@ id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
 estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
 estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
-estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1
+estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

estate/views/estate_menus.xml

@@ -9,4 +9,4 @@
             <menuitem id="menu_property_tag" action="estate_property_tag_action" name="Property Tags"/>
         </menuitem>
     </menuitem>
-</odoo>
+</odoo>

estate/views/estate_property_offer_views.xml

@@ -0,0 +1,31 @@
+<odoo>
+    <data>
+
+        <record id="estate_property_offer_list" model="ir.ui.view">
+            <field name="name">estate.property.offer.list</field>
+            <field name="model">estate.property.offer</field>
+            <field name="arch" type="xml">
+                <list editable="bottom"
+                      decoration-success="state == 'accepted'"
+                      decoration-danger="state == 'refused'">
+                    <field name="price"/>
+                    <field name="partner_id"/>
+                    <field name="date_deadline"/>
+                    <field name="validity"/>
+                    <button name="action_accept" type="object" class="oe_stat_button"
+                            icon="fa-check" string=" " invisible="state=='accepted'"/>
+                    <button name="action_refuse" type="object" class="oe_stat_button"
+                            icon="fa-close" string=" " invisible="state=='refused'"/>
+                    <field name="state" column_invisible="1"/>
+                    <field name="property_type_id"/>
+                </list>
+            </field>
+        </record>
+        <record id="estate_property_offer_action" model="ir.actions.act_window">
+            <field name="name">Offers</field>
+            <field name="res_model">estate.property.offer</field>
+            <field name="view_mode">list,form</field>
+            <field name="domain">[("property_type_id", "=", active_id)]</field>
+        </record>
+    </data>
+</odoo>

estate/views/estate_property_tag_views.xml

@@ -16,4 +16,4 @@
             <field name="view_mode">list,form</field>
         </record>
     </data>
-</odoo>
+</odoo>

estate/views/estate_property_type_views.xml

@@ -5,15 +5,23 @@
             <field name="model">estate.property.type</field>
             <field name="arch" type="xml">
                 <list string="Estate Property Type" editable="bottom">
+                    <field name="sequence" widget="handle"/>
                     <field name="name"/>
+                    <field name="offer_count"/>
+                    <button name="%(estate.estate_property_offer_action)d"
+                            type="action"
+                            class="oe_stat_button"
+                            icon="fa-list">
+                        <field name="offer_count"/>
+                    </button>
                 </list>
             </field>
         </record>
 
         <record id="estate_property_type_action" model="ir.actions.act_window">
             <field name="name">Estate Property Type</field>
             <field name="res_model">estate.property.type</field>
-            <field name="view_mode">list,form</field>
+            <field name="view_mode">list</field>
         </record>
     </data>
-</odoo>
+</odoo>