This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
[SQL-DS-CACHE-47]Add plasma native get timeout #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? Then could you also rename pull request title and commit log in the following format? See also: |
offthewall123
changed the title
|
@jikunshang Let's try this fix first. |
This was referenced Mar 22, 2021
winningsix
reviewed
Mar 23, 2021
| @@ -1067,7 +1067,7 @@ class ExternalCache(fiberType: FiberType) extends OapCache with Logging { | |||
| var fiberCache : FiberCache = null | |||
| logDebug(s"Cache hit, get from external cache.") | |||
| val plasmaClient = plasmaClientPool(clientRoundRobin.getAndAdd(1) % clientPoolSize) | |||
| val buf: ByteBuffer = plasmaClient.getObjAsByteBuffer(objectId, -1, false) | |||
| val buf: ByteBuffer = plasmaClient.getObjAsByteBuffer(objectId, 1000, false) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add plasma native get timeout
How was this patch tested?
E2E