This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
[SQL-DS-CACHE-47]PlasmaTimeOutWrapper #48
Closed
offthewall123
wants to merge
3
commits into
oap-project:branch-1.1-spark-3.x
from
offthewall123:Plasma_Timeout_Wrapper
Closed
[SQL-DS-CACHE-47]PlasmaTimeOutWrapper #48
offthewall123
wants to merge
3
commits into
oap-project:branch-1.1-spark-3.x
from
offthewall123:Plasma_Timeout_Wrapper
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jikunshang
changed the title
PlasmaTimeOutWrapper
[SQL-DS-CACHE-47]PlasmaTimeOutWrapper
Mar 18, 2021
jikunshang
reviewed
Mar 18, 2021
@@ -35,7 +35,7 @@ import com.google.common.cache._ | |||
import com.google.common.hash._ | |||
import com.intel.oap.common.unsafe.VMEMCacheJNI | |||
import org.apache.arrow.plasma | |||
import org.apache.arrow.plasma.exceptions.{DuplicateObjectException, PlasmaClientException} | |||
import org.apache.arrow.plasma.exceptions.{DuplicateObjectException, PlasmaClientException, PlasmaGetException} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have remove this exception PlasmaGetException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#18 see changes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, should be #39
Quick note. Please associate with a JIRA ID. |
I will close this one since we have another fix(#56 ), will re-open this one if it doesn't work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PlasmaTimeout wrapper
How was this patch tested?
e2e