-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link and image of NumPy comics to Contribute page #795
Open
MarsBarLee
wants to merge
11
commits into
numpy:main
Choose a base branch
from
MarsBarLee:numpy-comic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d41b920
Add link and image of NumPy comcis
5f038b4
Convert makefile to original state
9656ef1
Update image folder
MarsBarLee 59262ff
Add resized comic cover
a4063e1
Update image folder
MarsBarLee 58e0e91
Update image folder
MarsBarLee bf311bb
Update image folder
MarsBarLee bef69bc
Remove original numpy-comic.png
MarsBarLee b01d0d9
Update image size
MarsBarLee e0d75b2
Update image size
MarsBarLee 61f16d3
Update image size
MarsBarLee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -29,6 +29,13 @@ Our community aspires to treat everyone equally and to value all | |||||
contributions. We have a [Code of Conduct](/code-of-conduct) to foster an open | ||||||
and welcoming environment. | ||||||
|
||||||
### 'How to Contribute to NumPy' comic | ||||||
For a visual guide, check out this [comic](https://heyzine.com/flip-book/3e66a13901.html). | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
<a href="https://heyzine.com/flip-book/3e66a13901.html"> | ||||||
<img src="/images/content_images/numpy-comic.png" alt="NumPy Contributor comic book cover" width="200" height="309"> | ||||||
</a> | ||||||
|
||||||
### Writing code | ||||||
|
||||||
Programmers, this | ||||||
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarsBarLee Please remove this line of code. I don't think we need a header here.