Add link and image of NumPy comics to Contribute page #795
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I can also resize the image so it's smaller. The image is 780kB, I can make it smaller. The other image in the |
images/numpy-comic.png
Outdated
There was a problem hiding this comment.
@MarsBarLee To keep things organized, please move the image to the static/images/content_images/ folder.
@MarsBarLee A lighter image would be better. We prefer to keep them light to reduce load times. |
Co-authored-by: Inessa Pawson <[email protected]>
|
@InessaPawson Thank you for the suggestions! I worked with Mukulika and we fixed the image so it would display properly and at the right size. I wasn't able to get my local development server to show the image but it shows up on Netlify. The image size right now is hard-coded with pixels- would it be worthwhile to submit a separate PR with shortcode and flexible image size? I see on the About Us page, the sponsor images uses shortcode with I tried this shortcode method on a separate branch on my fork here. |
|
I think it would be nice if you could get the shortcode commit on this PR. If everything looks fine we can merge it and then improve things later if required. |
| @@ -29,6 +29,13 @@ Our community aspires to treat everyone equally and to value all | |||
| contributions. We have a [Code of Conduct](/code-of-conduct) to foster an open | |||
| and welcoming environment. | |||
|
|
|||
| ### 'How to Contribute to NumPy' comic | |||
There was a problem hiding this comment.
@MarsBarLee Please remove this line of code. I don't think we need a header here.
| @@ -29,6 +29,13 @@ Our community aspires to treat everyone equally and to value all | |||
| contributions. We have a [Code of Conduct](/code-of-conduct) to foster an open | |||
| and welcoming environment. | |||
|
|
|||
| ### 'How to Contribute to NumPy' comic | |||
| For a visual guide, check out this [comic](https://heyzine.com/flip-book/3e66a13901.html). | |||
There was a problem hiding this comment.
| For a visual guide, check out this [comic](https://heyzine.com/flip-book/3e66a13901.html). | |
| For a visual guide on how to contribute to NumPy, check out this [comic](https://heyzine.com/flip-book/3e66a13901.html). |
|
@MarsBarLee Your POC with the shortcode looks good. Feel free to make changes in this PR or submit a separate one. |
I've added a link and image to the 'How to Contribute to NumPy' comic in the Contribute page.
However, the image is showing up as broken like this:
@Mukulikaa Could you take a look at this?