Skip to content

fix: Remove godebug env var initialization #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vaibhavtiwari33 merged 2 commits into from
Dec 9, 2025
Merged

fix: Remove godebug env var initialization #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb8b75
Remove godebug env var initialization
vaibhavtiwari33 Nov 28, 2025
7d661cd
Merge branch 'main' into remove-godebug
vaibhavtiwari33 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/apis/numaflow/v1alpha1/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ const (
EnvCPULimit = "NUMAFLOW_CPU_LIMIT"
EnvMemoryRequest = "NUMAFLOW_MEMORY_REQUEST"
EnvMemoryLimit = "NUMAFLOW_MEMORY_LIMIT"
EnvGoDebug = "GODEBUG"
EnvServingMinPipelineSpec = "NUMAFLOW_SERVING_MIN_PIPELINE_SPEC"
EnvK8sServerVersion = "K8S_SERVER_VERSION"
EnvNumaflowRuntime = "NUMAFLOW_RUNTIME"
Expand Down
2 changes: 0 additions & 2 deletions pkg/apis/numaflow/v1alpha1/mono_vertex_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"encoding/json"
"errors"
"fmt"
"os"
"sort"
"strconv"
"time"
Expand Down Expand Up @@ -230,7 +229,6 @@ func (mv MonoVertex) GetDaemonDeploymentObj(req GetMonoVertexDaemonDeploymentReq
{Name: EnvNamespace, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.namespace"}}},
{Name: EnvPod, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.name"}}},
{Name: EnvMonoVertexObject, Value: encodedMonoVtx},
{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)},
}
envVars = append(envVars, req.Env...)
c := corev1.Container{
Expand Down
7 changes: 1 addition & 6 deletions pkg/apis/numaflow/v1alpha1/pipeline_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"encoding/base64"
"encoding/json"
"fmt"
"os"
"strings"
"time"

Expand Down Expand Up @@ -251,7 +250,6 @@ func (p Pipeline) GetSideInputsManagerDeployments(req GetSideInputDeploymentReq)
for i := 0; i < len(deployment.Spec.Template.Spec.Containers); i++ {
deployment.Spec.Template.Spec.Containers[i].Env = append(deployment.Spec.Template.Spec.Containers[i].Env, commonEnvVars...)
}
deployment.Spec.Template.Spec.InitContainers[0].Env = append(deployment.Spec.Template.Spec.InitContainers[0].Env, corev1.EnvVar{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)})
deployment.Spec.Template.Spec.Containers[0].Env = append(deployment.Spec.Template.Spec.Containers[0].Env, corev1.EnvVar{Name: EnvNumaflowRuntime, Value: "rust"})
deployments = append(deployments, deployment)
}
Expand All @@ -276,7 +274,6 @@ func (p Pipeline) GetDaemonDeploymentObj(req GetDaemonDeploymentReq) (*appv1.Dep
{Name: EnvNamespace, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.namespace"}}},
{Name: EnvPod, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.name"}}},
{Name: EnvPipelineObject, Value: encodedPipeline},
{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)},
}
envVars = append(envVars, req.Env...)
c := corev1.Container{
Expand Down Expand Up @@ -358,9 +355,7 @@ func (p Pipeline) GetDaemonDeploymentObj(req GetDaemonDeploymentReq) (*appv1.Dep
}

func (p Pipeline) getDaemonPodInitContainer(req GetDaemonDeploymentReq) corev1.Container {
envVars := []corev1.EnvVar{
{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)},
}
var envVars []corev1.EnvVar
envVars = append(envVars, req.Env...)
c := corev1.Container{
Name: CtrInit,
Expand Down
2 changes: 0 additions & 2 deletions pkg/apis/numaflow/v1alpha1/serving_pipeline_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"encoding/base64"
"encoding/json"
"fmt"
"os"

appv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -437,7 +436,6 @@ func (sp ServingPipeline) buildJetStreamSource(req GetServingPipelineResourceReq
func (sp ServingPipeline) getStreamValidationInitContainerSpec(req GetServingPipelineResourceReq) corev1.Container {
envVars := []corev1.EnvVar{
{Name: EnvPipelineName, Value: sp.GetPipelineName()},
{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)},
}
envVars = append(envVars, req.Env...)
c := corev1.Container{
Expand Down
2 changes: 0 additions & 2 deletions pkg/apis/numaflow/v1alpha1/vertex_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"encoding/json"
"errors"
"fmt"
"os"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -418,7 +417,6 @@ func (v Vertex) GetPodSpec(req GetVertexPodSpecReq) (*corev1.PodSpec, error) {
func (v Vertex) getInitContainers(req GetVertexPodSpecReq) []corev1.Container {
envVars := []corev1.EnvVar{
{Name: EnvPipelineName, Value: v.Spec.PipelineName},
{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)},
}
envVars = append(envVars, req.Env...)
initContainers := []corev1.Container{
Expand Down
Loading