Skip to content

Conversation

@vaibhavtiwari33
Copy link
Contributor

@vaibhavtiwari33 vaibhavtiwari33 commented Nov 28, 2025

What this PR does / why we need it

GODEBUG env variable isn't used anymore and hence be removed from being set at container level.

Related issues

Fixes #3091

Testing

Don't see GODEBUG env variable in init container anymore:
Screenshot 2025-12-09 at 11 03 27 AM

Before:
Screenshot 2025-12-09 at 10 55 38 AM

Spec used:

apiVersion: numaflow.numaproj.io/v1alpha1
kind: Pipeline
metadata:
  namespace: numaflow-system
  name: simple-kafka-generator
spec:
  templates:
    vertex:
      containerTemplate:
        env:
          - name: NUMAFLOW_DEBUG
            value: "true"
          - name: RUST_LOG
            value: "debug"
  vertices:
    - name: in
      source:
        # A self data generating source
        generator:
          rpu: 1
          duration: 1s
          keyCount: 5
          value: 5
    - name: cat
      scale:
        min: 1
      udf:
        container:
          image: quay.io/numaio/numaflow-js/mapper:stable
          imagePullPolicy: IfNotPresent
    - name: out
      sink:
        kafka:
          brokers:
            - kafka-svc.kafka.svc.cluster.local:9092
          topic: my-topic
  edges:
    - from: in
      to: cat
    - from: cat
      to: out

Special notes for reviewers

Anything notable for review (risk, rollout, follow-ups).

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.70%. Comparing base (895ac12) to head (7d661cd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3092      +/-   ##
==========================================
- Coverage   79.74%   79.70%   -0.04%     
==========================================
  Files         289      289              
  Lines       65028    65022       -6     
==========================================
- Hits        51854    51829      -25     
- Misses      12623    12642      +19     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yhl25 yhl25 marked this pull request as ready for review December 8, 2025 02:28
@yhl25 yhl25 requested a review from vigith as a code owner December 8, 2025 02:28
@vaibhavtiwari33 vaibhavtiwari33 marked this pull request as draft December 8, 2025 03:01
@vaibhavtiwari33 vaibhavtiwari33 marked this pull request as ready for review December 9, 2025 15:23
@vaibhavtiwari33 vaibhavtiwari33 merged commit 0d69308 into main Dec 9, 2025
27 checks passed
@vaibhavtiwari33 vaibhavtiwari33 deleted the remove-godebug branch December 9, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove setting of GODEBUG env variable in containers

4 participants