Update mpris implementation #279

acrisci · 2019-03-09T15:29:34Z

Add a basic mpris implementation by updating to mpris-service 2.0 and
uncommenting old mpris code.

Updates the requirements on [react-beautiful-dnd](https://github.com/atlassian/react-beautiful-dnd) to permit the latest version. - [Release notes](https://github.com/atlassian/react-beautiful-dnd/releases) - [Changelog](https://github.com/atlassian/react-beautiful-dnd/blob/master/CHANGELOG.md) - [Commits](https://github.com/atlassian/react-beautiful-dnd/commits/v10.0.3) Signed-off-by: dependabot[bot] <[email protected]>

…yarn/react-beautiful-dnd-tw-10.0.3 Update react-beautiful-dnd requirement from ^9.0.0 to ^10.0.3

Capitalized some text

Caps

I have started a Community-maintained package on chocolatey.org for this, as it was a request here chocolatey-community/chocolatey-package-requests#528

When a youtube playlist is entered in the search box, the different songs appear in the search results. Known limitations : - we should also be able to enter a song url (and not only playlist url) - not implemented - for now, only the first 100 songs of the playlist are displayed - some functionalities like "add all" or play all would make sense A first step towards uniformization of components was taken but isn't deployed everywhere yet (only in search results for now).

Add New Community-maintained package

Make Seekbar Container More Visible

Disable back and forward buttons when no history exists

feat(error): add a global ErrorBoundary component

feat: add a simple express rest api to remotly control nuclear

nukeop · 2019-03-15T21:07:01Z

Api is ready to go.

Add a basic mpris implementation by updating to mpris-service 2.0 and uncommenting old mpris code. Add additional methods to respond to mpris queries and methods to get and set the shuffle status, loop status, and position of the player. fixes nukeop#98

acrisci · 2019-03-16T23:17:51Z

Ok ready for testing.

nukeop · 2019-03-16T23:55:18Z

Fantastic, thank you for your contribution. I will test it as soon as possible.

nukeop · 2019-03-17T00:07:22Z

webpack.config.electron.js


 module.exports = env => {
  const entry = env && env.LINUX ? './server/main.dev.linux.js' : './server/main.dev.js';

  return {
    entry: entry,
+    resolve: {
+      alias: {
+        jsbi: path.resolve(__dirname, 'node_modules', 'jsbi', 'dist', 'jsbi-cjs.js')


what's this?

I'm not sure I need to look into why this works. @martpie came up with this. See this issue on mpris-service.

JSBI ships with a .mjs version of the library. The thing is Webpack's electron-main will try to import this .mjs instead of the classic common JS file. Then things goes terribly wrong.

To me, this solution is a hack, but I am not sure if the problem comes from jsbi builds, or node-dbus-next (which seems to be written in cjs, but without a transpiler/bundler).

I am also looking for a better solution, but I can't manage to get this library working is the first place 😄 so this is not my top-priority.

nukeop · 2019-03-18T20:57:07Z

I was just looking for a program to use mpris from the terminal, and found playerctl. Only after reading the readme and clicking the author's profile did I realize that it's you. Small world, or maybe you're just the most prominent in that niche.

acrisci · 2019-03-18T21:16:07Z

My thing is that I primarily do community-driven Linux Desktop projects 😎

This is part of a big project I'm doing to support mpris on electron players. It was inspired by people complaining on the Playerctl issue tracker that electron players don't work. I wrote about it here:

https://dubstepdish.com/index.php/2019/03/17/the-great-node-mpris-project/

nukeop · 2019-03-18T21:35:46Z

I also found out that dbus doesn't play nicely with tmux (apparently this combo causes an invalid socket location being saved in the environment, breaking playerctl).

nukeop · 2019-03-18T21:38:28Z

Have you seen something like this before?
This occurs on launch and is apparently caused by dbus-next, although it might be something on my end.

nukeop · 2019-03-18T21:41:29Z

Yep, it can't connect to dbus at all.

acrisci · 2019-03-18T21:55:24Z

Ah ok you're running a code path I haven't tested in dbus-next.

What is the value of $DBUS_SESSION_BUS_ADDRESS?

nukeop · 2019-03-18T21:57:32Z

unix:abstract=/tmp/dbus-pSgvVqOdpL,guid=1b9bd7435b409b88d4058c195c900e3d

acrisci · 2019-03-20T15:26:02Z

I can reproduce this by launching a shell with dbus-launch which uses the abstract socket scheme by default (dbus-launch /bin/zsh).

I'm pretty sure this is a problem with electron disabling some node api for the filesystem.

GPMDP works ok with the abstract socket code path, so that's promising. I'm trying to see if there are differences in the webpack or electron configuration that get this to work.

The origin of the error is here within the node-bindings library, a dependency of the node abstract-socket library.

They are trying to get the name of the file to find the abstract-socket bindings using the node Error class and getting a stack trace.

However, the stack trace object (st[i].getFileName() below) is returning undefined so it can't build the search path properly. I think if this function worked, then this bug would be fixed.

  Error.prepareStackTrace = function(e, st) {
    for (var i = 0, l = st.length; i < l; i++) {
      fileName = st[i].getFileName();
      if (fileName !== __filename) {
        if (calling_file) {
          if (fileName !== calling_file) {
            return;
          }
        } else {
          return;
        }
      }
    }
  };

  // run the 'prepareStackTrace' function above
  Error.captureStackTrace(dummy);

acrisci · 2019-03-20T15:46:42Z

Here is an issue on the node-bindings repo with a similar issue. This seems to be related to webpack doing some sort of eval on the bindings library. This issue seems to have been resolved in another project here. I tried just setting the webpack node config to

node: {
  __filename: true,
  __dirname: true
}

That allows fs to be used, but still doesn't resolve the issue so there might be more to it.

The abstract-socket dependency cannot be used in a bundle because it uses logic to find the bindings depending on a location in the filesystem within the node_modules directory

acrisci · 2019-03-22T13:08:06Z

Ok, so the real issue is that abstract-socket and bindings cannot be put in the bundle because the logic to find the bindings depends on the location of abstract-socket within the node_modules directory. And you can't include the compiled file in the bundle anyway.

I wish we didn't have to include this compiled file, but nodejs does not natively support abstract unix sockets so I don't see a way to write this dependency out.

This fixes the issue, but I'm not sure what the implications of using externals in the webpack config is.

I hope this doesn't put you in a bad spot.

nukeop · 2019-03-22T18:45:39Z

Does this work when we build the whole program in an Appimage, snap, etc? The whole problem with native dbus implementation was that it was impossible to bundle it correctly for these build targets, and it caused more trouble than it was worth. I'm fine if we have to use some black magic to get it to work, I'll test it later today.

nukeop · 2019-12-05T00:49:52Z

#555 implements mpris in our updated codebase. Thanks for helping us along the way.

trekiteasy and others added 30 commits January 21, 2019 11:42

nukeop#154 test platform for maximizing / full screen of the app

454e609

Code quality : == to ===

9372737

Code quality : == to ===

e82a02e

Code quality = != to !==

25763dd

Merge pull request nukeop#162 from ghostslayer989/dependabot/npm_and_…

decf66d

…yarn/react-beautiful-dnd-tw-10.0.3 Update react-beautiful-dnd requirement from ^9.0.0 to ^10.0.3

Caps

7475bff

Caps

790d3a2

Merge pull request nukeop#163 from ghostslayer989/master

4ba9d77

Capitalized some text

Caps

4b376fc

Merge pull request nukeop#167 from ghostslayer989/patch-1

b8aee1e

Caps

Fixed AddPlaylisTrackToQueue

df11299

Merge branch 'master' of https://github.com/nukeop/nuclear

ba18c78

Revert react-beautiful-dnd back to 9.0.0

3652bbb

Add Community-maintained packages

80022fc

I have started a Community-maintained package on chocolatey.org for this, as it was a request here chocolatey-community/chocolatey-package-requests#528

Merge branch 'master' of https://github.com/nukeop/nuclear

505bcd9

Merge pull request nukeop#179 from JourneyOver/patch-1

980f230

Add New Community-maintained package

Cleaning console.log statements

be46815

Added artist name in playlist search results

a408a35

Update README.md

78042b2

Change seekbar_container color

c79b713

Remove old background-color

a86aefb

Merge remote-tracking branch 'upstream/master'

78d0089

Merge pull request nukeop#183 from 1yzo/master

8ac07b1

Make Seekbar Container More Visible

Update to use electron-timber

f395c50

Merge branch 'master' of https://github.com/nukeop/nuclear

0ae9758

Redirect to dashboard on program start

6983421

Display seekbar more prominently

db7b382

Remove route transitions - program feels a lot snappier

9ab1027

nukeop and others added 7 commits March 13, 2019 15:38

Update index.js

b10d7f9

Merge pull request nukeop#282 from hibroseph/disable-history-button

0d7bf88

Disable back and forward buttons when no history exists

Fix nukeop#285

4ee1016

feat(error): add a global ErrorBoundary component

9c42411

fix(error): fix typo in toast message

49c0de6

Merge pull request nukeop#290 from charjac/feat.error

1232433

feat(error): add a global ErrorBoundary component

Merge pull request nukeop#278 from charjac/feat.httpApi

45edc75

feat: add a simple express rest api to remotly control nuclear

Update mpris implementation

dad078f

Add a basic mpris implementation by updating to mpris-service 2.0 and uncommenting old mpris code. Add additional methods to respond to mpris queries and methods to get and set the shuffle status, loop status, and position of the player. fixes nukeop#98

acrisci force-pushed the mpris-update branch from a4f2202 to dad078f Compare March 16, 2019 22:30

nukeop reviewed Mar 17, 2019

View reviewed changes

acrisci changed the title ~~[WIP] Update mpris implementation~~ Update mpris implementation Mar 17, 2019

acrisci mentioned this pull request Mar 18, 2019

Player implementation status dbusjs/mpris-service#30

Closed

8 tasks

Exclude bindings and abstract-socket from bundle

452fe2f

The abstract-socket dependency cannot be used in a bundle because it uses logic to find the bindings depending on a location in the filesystem within the node_modules directory

nukeop force-pushed the master branch from 13f1d88 to 81de3d1 Compare September 30, 2019 23:48

nukeop closed this Dec 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update mpris implementation #279

Update mpris implementation #279

acrisci commented Mar 9, 2019

nukeop commented Mar 15, 2019

acrisci commented Mar 16, 2019

nukeop commented Mar 16, 2019

nukeop Mar 17, 2019

acrisci Mar 17, 2019

martpie Mar 17, 2019 •

edited

Loading

nukeop commented Mar 18, 2019

acrisci commented Mar 18, 2019

nukeop commented Mar 18, 2019

nukeop commented Mar 18, 2019

nukeop commented Mar 18, 2019

acrisci commented Mar 18, 2019

nukeop commented Mar 18, 2019

acrisci commented Mar 20, 2019 •

edited

Loading

acrisci commented Mar 20, 2019

acrisci commented Mar 22, 2019 •

edited

Loading

nukeop commented Mar 22, 2019

nukeop commented Dec 5, 2019

Update mpris implementation #279

Update mpris implementation #279

Conversation

acrisci commented Mar 9, 2019

nukeop commented Mar 15, 2019

acrisci commented Mar 16, 2019

nukeop commented Mar 16, 2019

nukeop Mar 17, 2019

Choose a reason for hiding this comment

acrisci Mar 17, 2019

Choose a reason for hiding this comment

martpie Mar 17, 2019 • edited Loading

Choose a reason for hiding this comment

nukeop commented Mar 18, 2019

acrisci commented Mar 18, 2019

nukeop commented Mar 18, 2019

nukeop commented Mar 18, 2019

nukeop commented Mar 18, 2019

acrisci commented Mar 18, 2019

nukeop commented Mar 18, 2019

acrisci commented Mar 20, 2019 • edited Loading

acrisci commented Mar 20, 2019

acrisci commented Mar 22, 2019 • edited Loading

nukeop commented Mar 22, 2019

nukeop commented Dec 5, 2019

martpie Mar 17, 2019 •

edited

Loading

acrisci commented Mar 20, 2019 •

edited

Loading

acrisci commented Mar 22, 2019 •

edited

Loading