-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added a youtube playlist tracks identifier
When a youtube playlist is entered in the search box, the different songs appear in the search results. Known limitations : - we should also be able to enter a song url (and not only playlist url) - not implemented - for now, only the first 100 songs of the playlist are displayed - some functionalities like "add all" or play all would make sense A first step towards uniformization of components was taken but isn't deployed everywhere yet (only in search results for now).
- Loading branch information
1 parent
ba18c78
commit 5a24449
Showing
12 changed files
with
503 additions
and
169 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5a24449
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we often have to merge master back, why don't we work on separate branches from now on if we're working on larger features? This way we'll have more control over merging/reverting features.
5a24449
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree for larger works (such as this one). Will do this on future features. I think I should continue working directly on master for small bug fixes or code style fixes.
5a24449
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed.