Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1587: Exposes MaxInFlight, BatchConfig for SQL Destinations #2885

Merged
merged 5 commits into from
Oct 31, 2024

wires up new params to backend models, refactors into dto methods

f0a1d95
Select commit
Loading
Failed to load commit list.
Merged

NEOS-1587: Exposes MaxInFlight, BatchConfig for SQL Destinations #2885

wires up new params to backend models, refactors into dto methods
f0a1d95
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 0s

No report found to compare against

View this Pull Request on Codecov

No report found to compare against

Details

Codecov Report

Attention: Patch coverage is 16.00000% with 168 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@27edd03). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ernal/benthos/benthos-builder/builders/sql-util.go 0.00% 63 Missing ⚠️
backend/sql/postgresql/models/models.go 34.04% 59 Missing and 3 partials ⚠️
internal/benthos/benthos-builder/builders/sql.go 0.00% 17 Missing ⚠️
...al/benthos/benthos-builder/builders/generate-ai.go 0.00% 9 Missing ⚠️
...ernal/benthos/benthos-builder/builders/generate.go 0.00% 9 Missing ⚠️
...nternal/benthos/benthos-builder/builders/aws-s3.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage        ?   38.74%           
=======================================
  Files           ?      315           
  Lines           ?    36095           
  Branches        ?        0           
=======================================
  Hits            ?    13986           
  Misses          ?    20417           
  Partials        ?     1692

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov