Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1587: Exposes MaxInFlight, BatchConfig for SQL Destinations #2885

Conversation

nickzelei
Copy link
Member

No description provided.

Copy link

linear bot commented Oct 30, 2024

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 6:53pm

@nickzelei nickzelei added the enhancement New feature or request label Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 31, 2024, 6:53 PM

@nickzelei nickzelei changed the title NEOS-1587: expose ability to configure max in flight for sql NEOS-1587: Expose MaxInFlight, BatchConfig in SQL Destinations Oct 30, 2024
@nickzelei nickzelei changed the title NEOS-1587: Expose MaxInFlight, BatchConfig in SQL Destinations NEOS-1587: Exposes MaxInFlight, BatchConfig for SQL Destinations Oct 30, 2024
@nickzelei nickzelei force-pushed the nick/neos-1587-expose-ability-to-configure-max-in-flight-for-sql branch from 3137fbd to 451a0c5 Compare October 31, 2024 17:50
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 16.00000% with 168 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@27edd03). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ernal/benthos/benthos-builder/builders/sql-util.go 0.00% 63 Missing ⚠️
backend/sql/postgresql/models/models.go 34.04% 59 Missing and 3 partials ⚠️
internal/benthos/benthos-builder/builders/sql.go 0.00% 17 Missing ⚠️
...al/benthos/benthos-builder/builders/generate-ai.go 0.00% 9 Missing ⚠️
...ernal/benthos/benthos-builder/builders/generate.go 0.00% 9 Missing ⚠️
...nternal/benthos/benthos-builder/builders/aws-s3.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2885   +/-   ##
=======================================
  Coverage        ?   38.74%           
=======================================
  Files           ?      315           
  Lines           ?    36095           
  Branches        ?        0           
=======================================
  Hits            ?    13986           
  Misses          ?    20417           
  Partials        ?     1692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei marked this pull request as ready for review October 31, 2024 18:31
@nickzelei nickzelei merged commit c3ad106 into main Oct 31, 2024
21 checks passed
@nickzelei nickzelei deleted the nick/neos-1587-expose-ability-to-configure-max-in-flight-for-sql branch October 31, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants