Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdp: add Kconfigs for no-copy #20276

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

mif1-nordic
Copy link
Contributor

Requires #20017

@mif1-nordic mif1-nordic requested review from a team as code owners February 10, 2025 14:22
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 10, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 10, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: a0cd43d75a1d152fb626eb1ef454ca8514b30ebf

more details

sdk-nrf:

PR head: a0cd43d75a1d152fb626eb1ef454ca8514b30ebf
merge base: 1d59812af0b855bc9df4e3cef5acc9fda7f3080a
target head (main): 83d7c5cc16e17ebfc07ff6e1708e525c5e3930d5
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  │ Kconfig
drivers
│  ├── mspi
│  │  │ Kconfig.nrfe

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 30
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@masz-nordic masz-nordic changed the title No copy kconfigs sdp: add Kconfigs for no-copy Feb 10, 2025
@masz-nordic masz-nordic added this to the 3.0.0 milestone Feb 10, 2025
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

drivers/mspi/Kconfig.nrfe Show resolved Hide resolved
drivers/mspi/Kconfig.nrfe Outdated Show resolved Hide resolved
drivers/mspi/Kconfig.nrfe Outdated Show resolved Hide resolved
applications/sdp/mspi/Kconfig Outdated Show resolved Hide resolved
Added:
MSPI_NRFE_IPC_NO_COPY,
MSPI_NRFE_IPC_COPY Kconfigs.

Signed-off-by: Michal Frankiewicz <[email protected]>
Added:
SDP_MSPI_IPC_NO_COPY,
SDP_MSPI_IPC_COPY Kconfigs.

Signed-off-by: Michal Frankiewicz <[email protected]>
Comment on lines +10 to +12
If y Data is passed through IPC by reference,
this requires both cores to be able to access each others memory spaces.
If n Data is passed through IPC by copy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
If y Data is passed through IPC by reference,
this requires both cores to be able to access each others memory spaces.
If n Data is passed through IPC by copy.
If enabled data is passed through IPC by reference,
this requires both cores to be able to access each others memory spaces.
If disabled data is passed through IPC by copy.

Same goes for FLPR side.

@masz-nordic masz-nordic merged commit c80b765 into nrfconnect:main Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants