Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: sdp: no copy IPC #20116

Merged
merged 2 commits into from
Feb 14, 2025
Merged

applications: sdp: no copy IPC #20116

merged 2 commits into from
Feb 14, 2025
+95 −55

Conversation

mif1-nordic
Copy link
Contributor

@mif1-nordic mif1-nordic commented Jan 29, 2025 •
edited
Loading

Requires #20276

@mif1-nordic mif1-nordic requested review from a team as code owners January 29, 2025 14:43
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 29, 2025
@masz-nordic masz-nordic changed the title No copy ipc applications: sdp: no copy IPC Jan 29, 2025
@masz-nordic masz-nordic added this to the 3.0.0 milestone Jan 29, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 29, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 35

Inputs:

Sources:

sdk-nrf: PR head: 2b451a88b3ee9a0bf374d32c2c5811b55d723976

more details

sdk-nrf:

PR head: 2b451a88b3ee9a0bf374d32c2c5811b55d723976
merge base: f6316193c36c97aa6bd6b68d363e9aab9c8697bc
target head (main): f6316193c36c97aa6bd6b68d363e9aab9c8697bc
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 32
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 7 times, most recently from bdeae8e to 5d6c142 Compare January 30, 2025 13:05
@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 10 times, most recently from f2fd5ad to eccb841 Compare February 6, 2025 13:46
magp-nordic
magp-nordic reviewed Feb 6, 2025
View reviewed changes
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 2 times, most recently from 523a617 to b291381 Compare February 10, 2025 14:20
@mif1-nordic mif1-nordic requested a review from a team as a code owner February 10, 2025 14:20
@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 5 times, most recently from 49831df to 70129c7 Compare February 11, 2025 09:25
nordicjm
nordicjm reviewed Feb 11, 2025
View reviewed changes
drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved
applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved
@mif1-nordic mif1-nordic mentioned this pull request Feb 12, 2025
Open
@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 4 times, most recently from 7236e5b to 7de3108 Compare February 12, 2025 10:18
magp-nordic
magp-nordic approved these changes Feb 12, 2025
View reviewed changes
drivers/mspi/mspi_nrfe.c Show resolved Hide resolved
drivers/mspi/mspi_nrfe.c Show resolved Hide resolved
@mif1-nordic mif1-nordic force-pushed the no_copy_ipc branch 3 times, most recently from 6400384 to 39ef739 Compare February 13, 2025 12:09
@mif1-nordic
drivers: mspi: No copy IPC-drivers
bcc6280 
Implemented option to pass data between cores
through IPC by reference.

Signed-off-by: Michal Frankiewicz <[email protected]>
@mif1-nordic
applications: sdp: mspi: No copy IPC-applications
2b451a8 
Implemented option to pass data between cores
through IPC by reference.

Signed-off-by: Michal Frankiewicz <[email protected]>
masz-nordic
masz-nordic reviewed Feb 13, 2025
View reviewed changes
drivers/mspi/mspi_nrfe.c
if (rc < 0) {
LOG_ERR("Packet transfer error: %d", rc);
#ifdef CONFIG_MSPI_NRFE_IPC_NO_COPY
/* Check for alignlemt problems. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* Check for alignlemt problems. */
/* Check for alignment problems. */

Also, please add explanation why this is needed.

drivers/mspi/mspi_nrfe.c
uint32_t len = sizeof(nrfe_mspi_xfer_packet_msg_t) + packet->num_bytes;
#endif
uint8_t buffer[len];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This buffer should be word aligned.
Also, it really should not be a local variable length array, but that can be fixed separately.

masz-nordic
masz-nordic approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@masz-nordic masz-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments will be addressed in a separate PR.

@masz-nordic masz-nordic merged commit 434a16f into nrfconnect:main Feb 14, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm left review comments

@jaz1-nordic jaz1-nordic jaz1-nordic left review comments

@masz-nordic masz-nordic masz-nordic approved these changes

@magp-nordic magp-nordic magp-nordic approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mif1-nordic @NordicBuilder @nordicjm @masz-nordic @magp-nordic @jaz1-nordic