-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloudflare api to fix removed field #60
Conversation
looks like the build is failing in CI |
Yup, I can have a look at it tonight. |
I reran crate2nix, hopefully that's what the problem was. It seems to have changed the format of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the fix. I would just request you maybe squash the first two commits of the PR into one, and it should be ready to merge.
cb45b3d
to
2550b84
Compare
Sure, done |
I'm happy to update nixpkgs if you create a new release, or I can just update to the latest commit |
tagged as v0.2.1 |
A patch for cloudflare/cloudflare-rs/pull/240
Fixes #57
I've included @jcgruenhage's make-owner-fields-optional changes in my cloudflare-rs PR.
Removes some unused imports that no longer exist (
ApiClient
), and the change inapi.rs
is to coerce the error type fromClient::new
, as I'm assuming they're now returning their own error type. I can make this nicer if you want.I can confirm that this works with
A
records, I haven't tested withAAAA
records but I can't see why it wouldn't also work.Before:
After - when there is no change needed:
After - when the DNS record needs changing: