Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfdyndns: 0.2.0 -> 0.2.1 #323855

Merged
merged 1 commit into from
Jul 2, 2024
Merged

cfdyndns: 0.2.0 -> 0.2.1 #323855

merged 1 commit into from
Jul 2, 2024

Conversation

Wyn-Price
Copy link
Contributor

@Wyn-Price Wyn-Price commented Jul 1, 2024

Description of changes

nrdxp/cfdyndns#60

Updates cloudflare-rs version, fixing an API change issue. Cargo.lock is copied from nrdxp/cfdyndns.

It may be worth setting passthru.updateScript = nix-update-script { };, as this is a fairly trivial update.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 1, 2024
@ofborg ofborg bot requested a review from colemickens July 1, 2024 18:14
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 1, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked Cargo.lock

@NickCao NickCao merged commit 7cbbe77 into NixOS:master Jul 2, 2024
32 checks passed
@Aleksanaa Aleksanaa mentioned this pull request Jul 3, 2024
13 tasks
@fadenb
Copy link
Contributor

fadenb commented Jul 9, 2024

@Wyn-Price do you think this should be backported to 24.05? I think it should as the version currently used by 24.05 is non-functional.

@Wyn-Price
Copy link
Contributor Author

@fadenb sounds like a good idea, I can't think why not. The fix is simple enough that it probably can just be automatically backported, just need a maintainer to do so.

@NickCao NickCao added the backport release-24.05 Backport PR automatically label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants