build: add support for armv7 binary release #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmussier
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
=======================================
Coverage 71.34% 71.34%
=======================================
Files 45 45
Lines 2174 2174
=======================================
Hits 1551 1551
Misses 429 429
Partials 194 194 ☔ View full report in Codecov by Sentry. |
shizhMSFT
changed the title
|
@lmussier Could you fix the DCO check? |
shizhMSFT
reviewed
Jun 4, 2024
|
@lmussier Thanks for your contribution. You may refer to this doc to fix the DCO issue and submit signed git commit: https://github.com/notaryproject/.github/blob/main/CONTRIBUTING.md#commit |
I'll do. |
lmussier
force-pushed
the
main
branch
2 times, most recently
from
32e8a23
to
ff9b906
Compare
Signed-off-by: lmussier <[email protected]>
…darwin Signed-off-by: lmussier <[email protected]>
|
Should be good know. |
|
Hi @notaryproject/notaryproject-notation-maintainers anything I have to do to retrigger a DCO check - I lmight have missed something also... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify targeted goarch and ignore irelevant configs (e.g windows / arm and darwi n/ arm)