Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you add Arm 32 in official release artefacts? #943

Open
lmussier opened this issue May 15, 2024 · 6 comments · May be fixed by #956
Open

Could you add Arm 32 in official release artefacts? #943

lmussier opened this issue May 15, 2024 · 6 comments · May be fixed by #956
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@lmussier
Copy link

Is your feature request related to a problem?

I would like to use notation on arm32 processors.

What solution do you propose?

I'd like to see arm in the official releases

What alternatives have you considered?

Build notation on my own

Any additional context?

No response

@lmussier lmussier added enhancement New feature or request triage Need to triage labels May 15, 2024
@lmussier lmussier changed the title Arm 32 release Could you add Arm 32 in official release artefacts? May 15, 2024
@lmussier
Copy link
Author

More or less the same request as this one oras-project/oras#364 :)

@FeynmanZhou FeynmanZhou removed the triage Need to triage label May 17, 2024
@FeynmanZhou FeynmanZhou added this to the Future milestone May 17, 2024
@yizha1
Copy link
Contributor

yizha1 commented May 20, 2024

@lmussier Are you interested in contributing to fix this issue?

@FeynmanZhou FeynmanZhou added the good first issue Good for newcomers label May 22, 2024
@lmussier
Copy link
Author

lmussier commented May 24, 2024

Short answer, yes.
I can make it compile (already done in fact) but I was not able to run tests, I'll give it a try and if tests are ok I can definitively provide a PR for that.
But I'm affraid is tests are KO I don't have the competencies to make them pass.

@yizha1
Copy link
Contributor

yizha1 commented May 25, 2024

I appreciate your interest @lmussier. You can start working on it and the Notation maintainers will assist you if you encounter any issues. Feel free to ask your questions here. /cc: @notaryproject/notaryproject-notation-maintainers

@lmussier
Copy link
Author

lmussier commented Jun 3, 2024

Hi @yizha1,
The easiest is done in #956
Unit tests (make test) are ok, but I encounter some weird issues with e2e tests, they won't pass on a the current master head.
See e2e.log, before this run there were failed tests around the truststore.

@FeynmanZhou FeynmanZhou linked a pull request Jun 4, 2024 that will close this issue
@yizha1 yizha1 modified the milestones: Future, 1.2.0 Jun 4, 2024
@yizha1
Copy link
Contributor

yizha1 commented Jun 4, 2024

@lmussier If your PR passes verification and merged, it should be fine. Your log indicated some throttling issues from Docker hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants