Skip to content

Add web-infra onboarding docs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions onboarding/web-infra.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# @nodejs/web-infra Onboarding

This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra).

Please note these tasks should only be performed after an individual's nomination has passed.

## Tasks

Tasks prefixed by `Member:` are for the new member to complete.
Tasks prefixed by `Web Admin:` are for a member of `@nodejs/web-admins` to complete.
Comment on lines +9 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we can just say "A web admin should ...", "The onboardee should ...". in each task


- [ ] Web Admin: Create an issue in [nodejs/web-team](https://github.com/nodejs/web-team) specifically for onboarding the member and include this list in it.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly think this might be better as an issue template and this doc just links to it, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Member can do this in their "Add xyz to the list of MEMBERS" PR, and the team will check off each task before merging?

- Please link any additional issues or PRs relating to the member's onboarding to this issue for record keeping.
- [ ] Web Admin: Recommend member have some form of physical 2FA (i.e. Yubikey) or passkey enabled on their GitHub account, and that any SSH or GPG key attached to their GitHub account have passphrases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js Organization requires 2FA, so this isn't something we need to explicitly say.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to state this -- the org requires 2FA, this is a recommendation specifically to use a physical factor, which AIUI is not enforced at the org level.

- [ ] Web Admin: Recommend member sign their Git commits if not already doing so.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the "Web Admin: Recommend" aren't really needed, and should be put as a separate section "# Recommendations for New Members" of this file?

- [ ] Web Admin: Add member to the [@nodejs/web-infra](https://github.com/orgs/nodejs/teams/web-infra) team.
- [ ] Member: Add yourself to the [membership list document](https://github.com/nodejs/web-team/blob/main/MEMBERS.md#nodejs-web-infra-team-nodejsweb-infra).
- [ ] Member: Open an issue in [nodejs/admin](https://github.com/nodejs/admin) requesting access to the Web Infra 1Password vault.
- [ ] Web Admin: Invite member to Node.js' Sentry account.
- [ ] Member: Enable physical or passkey 2FA on their Sentry account.
- [ ] Web Admin: Invite member to Node.js' Vercel account.
- [ ] Member: Enable physical or passkey 2FA on their Vercel account.

There currently is not a set level of access that @nodejs/web-infra members have on Cloudflare.

Should you need additional access, it may be granted, however, access is not given by default.
You may be granted access if needed, but will not be given it initially since we do not control it.
Loading