Add web-infra onboarding docs

[flakey5]

Re #5

Note: blocked until nodejs/admin#984 goes through since this mentions the web-admins team.

[avivkeller]

Perhaps make an ONBOARDING.md, with a # @nodejs/web-infra section?

[ovflowd]

@flakey5 I also believe we could document our Slack channels on the onboarding doc and what they server for. (there's the website one, alerts one, i18n one for website, and others I gues?)

[ovflowd]

OOC, why is the PR blocked?

[ovflowd]

@flakey5 I forgot, we also have this list for Crowdin: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L175

Can you also add this to the onboarding docs, we also need the current remaining members of web-infra added there!

[ovflowd]

Same for: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241

[avivkeller]

OOC, why is the PR blocked?

Per the PR description,

Note: blocked until nodejs/admin#984 goes through since this mentions the web-admins team.

[ovflowd]

Hey @flakey5 just wondering if you're still OOO (vacations); Should we take over this PR or?

[flakey5]

just wondering if you're still OOO (vacations); Should we take over this PR or?

Apologizes got side tracked, updated from reviews but I think this should still be blocked since nodejs/admin#984 is still open

[ovflowd]

just wondering if you're still OOO (vacations); Should we take over this PR or?

Apologizes got side tracked, updated from reviews but I think this should still be blocked since nodejs/admin#984 is still open

Agreed

[avivkeller]

Looks good. These changes make this uniform with the @nodejs/nodejs-website onboarding guide.

[avivkeller]

Suggested change

	# @nodejs/web-infra Onboarding
	This document is an outline of the tasks necessary to onboard a new member of the Web Infrastructure team (@nodejs/web-infra).
	Please note these tasks should only be performed after an individual's nomination has passed.
	To start the nomination process, see [GOVERNANCE.md](../GOVERNANCE.md).
	## Tasks
	## @nodejs/web-infra Onboarding

Let's make this uniform w/ https://github.com/nodejs/web-team/blob/main/onboarding/nodejs-website.md?plain=1

[flakey5]

I think we should keep the two paragraphs since it gives a general outline and explicitly states when these steps should happen. While both can be inferred implicitly, I still think it's better to explicitly state these so avoid confusion or misinterpretation regardless of how unlikely

[ovflowd]

Should we also give access to Cloudflare even if in a read-only capacity?

[MattIPv4]

I have admin read-only, I had assumed that was something all of web-infra has so we can see what's going on there

[flakey5]

I think that is up to the build team, I do think admin read only would be nice but right now there's no set level of access (i.e. I have workers read and R2 read atm)

[avivkeller]

@flakey5 If all of my comments are merged, it'll unblock this PR, since, it removes any references to "Web Admins". IMO, while they do exist (@ovflowd and @bmuenzenmeyer), they don't need to be explicitly stated as the ones to perform the action.

This is also consistent with other onboarding guides:

• https://github.com/nodejs/TSC/blob/main/ONBOARDING.md
• https://github.com/nodejs/build/blob/main/ONBOARDING.md
• etc

For example,

• A Web Admin should add the nominee to the @nodejs/web-infra team.

This can also be performed by members of the TSC.

• A Web Admin should recommend the nominee sign their Git commits.

This is a general recommendation, it doesn't really need to come from a specific person

(Feel free to disagree with me tho)

[flakey5]

For the latter of the examples I agree, but still I think the former should be explicitly stated as to whom should perform the action to avoid any potential confusion. There are cases like you pointed out where it's not just Web Admins that can perform an action, but still it still should generally be Web Admins doing it.

Regardless, if the rule we're going with is

• actions for the nominee to do start with The **Nominee** should ...
• actions for anyone with necessary access to do start with anything else

then that's explicit enough for me at least

[flakey5]

Re nodejs/build#4127, what would the process be for getting added to search console?

[avivkeller]

For the latter of the examples I agree, but still I think the former should be explicitly stated as to whom should perform the action to avoid any potential confusion.

Whatever you think is best, it's your PR :-)