Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Gracefully warn when no motion components are found #83

Merged
merged 2 commits into from
Oct 31, 2024
Merged

FIX: Gracefully warn when no motion components are found #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
765a755
Fix typo (config.loggers.interface not .interfaces)
jczimm Oct 30, 2024
5a7ffd9
Add self as contributor to .zenodo.json
jczimm Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .zenodo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
},
{
"name": "Caballero Gaudes, Cesar"
},
{
"affiliation": "Department of Psychology, University of Southern California",
"name": "Zimmerman, Jacob C.",
"orcid": "0000-0002-6010-8086"
}
],
"creators": [
Expand Down
2 changes: 1 addition & 1 deletion src/fmripost_aroma/interfaces/confounds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@

# Return dummy list of ones if no noise components were found
if motion_ics.size == 0:
config.loggers.interfaces.warning('No noise components were classified')
config.loggers.interface.warning('No noise components were classified')

Check warning on line 94 in src/fmripost_aroma/interfaces/confounds.py

View check run for this annotation

Codecov / codecov/patch

src/fmripost_aroma/interfaces/confounds.py#L94 

Added line #L94 was not covered by tests
return None, mixing_out

# return dummy lists of zeros if no signal components were found
Expand Down