Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Gracefully warn when no motion components are found #83

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

jczimm
Copy link
Contributor

@jczimm jczimm commented Oct 30, 2024

Changes proposed in this pull request

Fixes #82

Documentation that should be reviewed

N/A

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (8cba0aa) to head (5a7ffd9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/interfaces/confounds.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   30.59%   30.59%           
=======================================
  Files          26       26           
  Lines        2363     2363           
  Branches      286      286           
=======================================
  Hits          723      723           
  Misses       1617     1617           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 5d5b065 into nipreps:main Oct 31, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ica_aroma_confound_extraction crashes when no motion components are found
2 participants