Add tests for reading and writing digital lines with varying lines pe… #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
approved these changes
Jul 19, 2024
bkeryan
reviewed
Jul 19, 2024
zhindes
approved these changes
Jul 20, 2024
bkeryan
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r channel
What does this Pull Request accomplish?
This pull request adds two tests that validate reading and writing digital lines when multiple ports are active with different line counts. The tests are written to work with a PXIe-6363 with 32 lines on port 0 and 8 lines on ports 1 and 2. The tests ensure that the reads and writes complete successfully and provide minimal data validation.
The linter also corrected one line with incorrect style which I included in the PR.
Why should this Pull Request be merged?
Increase test coverage
What testing has been done?
Tests were run locally and pass